From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55757 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OSSNh-0002jk-KD
	for qemu-devel@nongnu.org; Sat, 26 Jun 2010 06:13:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <hch@lst.de>) id 1OSSNg-0002ll-4G
	for qemu-devel@nongnu.org; Sat, 26 Jun 2010 06:13:01 -0400
Received: from verein.lst.de ([213.95.11.210]:37449)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <hch@lst.de>)
	id 1OSSNf-0002ld-On
	for qemu-devel@nongnu.org; Sat, 26 Jun 2010 06:13:00 -0400
Date: Sat, 26 Jun 2010 12:12:58 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20100626101258.GD27699@lst.de>
References: <1277484812-22012-1-git-send-email-armbru@redhat.com>
	<1277484812-22012-10-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1277484812-22012-10-git-send-email-armbru@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of
	snapshot device
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Of course specifying an explicit medium for snapshot, be that the
snapshot section of a qcow2 image or just a separate flat file and
managing that one explicitly would be even better.