From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60675 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OScOR-0007K4-W8 for qemu-devel@nongnu.org; Sat, 26 Jun 2010 16:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OScOQ-00030d-PL for qemu-devel@nongnu.org; Sat, 26 Jun 2010 16:54:27 -0400 Received: from one.firstfloor.org ([213.235.205.2]:40966) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OScOQ-00030L-J8 for qemu-devel@nongnu.org; Sat, 26 Jun 2010 16:54:26 -0400 Date: Sat, 26 Jun 2010 22:54:21 +0200 From: Andi Kleen Message-ID: <20100626205421.GA10339@basil.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] Don't declare XSAVE as supported List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: andre.przywara@amd.com, qemu-devel@nongnu.org Don't declare XSAVE as supported i386 cpuid.c currently claims XSAVE is supported in the CPUID filter, but that's not true: Only FXSAVE is supported. Remove that bit from the filter. Signed-off-by: Andi Kleen diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index 6a0f7ca..4251a29 100644 --- a/target-i386/cpuid.c +++ b/target-i386/cpuid.c @@ -241,11 +241,11 @@ typedef struct x86_def_t { /* missing: CPUID_VME, CPUID_DTS, CPUID_SS, CPUID_HT, CPUID_TM, CPUID_PBE */ #define TCG_EXT_FEATURES (CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | \ - CPUID_EXT_CX16 | CPUID_EXT_POPCNT | CPUID_EXT_XSAVE | \ + CPUID_EXT_CX16 | CPUID_EXT_POPCNT | \ CPUID_EXT_HYPERVISOR) /* missing: CPUID_EXT_DTES64, CPUID_EXT_DSCPL, CPUID_EXT_VMX, CPUID_EXT_EST, - CPUID_EXT_TM2, CPUID_EXT_XTPR, CPUID_EXT_PDCM */ + CPUID_EXT_TM2, CPUID_EXT_XTPR, CPUID_EXT_PDCM, CPUID_EXT_XSAVE */ #define TCG_EXT2_FEATURES ((TCG_FEATURES & EXT2_FEATURE_MASK) | \ CPUID_EXT2_NX | CPUID_EXT2_MMXEXT | CPUID_EXT2_RDTSCP | \ CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT)