* [Qemu-devel] [PATCH] Don't declare XSAVE as supported
@ 2010-06-26 20:54 Andi Kleen
2010-07-01 23:56 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2010-06-26 20:54 UTC (permalink / raw)
To: andre.przywara, qemu-devel
Don't declare XSAVE as supported
i386 cpuid.c currently claims XSAVE is supported in the CPUID filter,
but that's not true: Only FXSAVE is supported. Remove that bit
from the filter.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 6a0f7ca..4251a29 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -241,11 +241,11 @@ typedef struct x86_def_t {
/* missing:
CPUID_VME, CPUID_DTS, CPUID_SS, CPUID_HT, CPUID_TM, CPUID_PBE */
#define TCG_EXT_FEATURES (CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | \
- CPUID_EXT_CX16 | CPUID_EXT_POPCNT | CPUID_EXT_XSAVE | \
+ CPUID_EXT_CX16 | CPUID_EXT_POPCNT | \
CPUID_EXT_HYPERVISOR)
/* missing:
CPUID_EXT_DTES64, CPUID_EXT_DSCPL, CPUID_EXT_VMX, CPUID_EXT_EST,
- CPUID_EXT_TM2, CPUID_EXT_XTPR, CPUID_EXT_PDCM */
+ CPUID_EXT_TM2, CPUID_EXT_XTPR, CPUID_EXT_PDCM, CPUID_EXT_XSAVE */
#define TCG_EXT2_FEATURES ((TCG_FEATURES & EXT2_FEATURE_MASK) | \
CPUID_EXT2_NX | CPUID_EXT2_MMXEXT | CPUID_EXT2_RDTSCP | \
CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Don't declare XSAVE as supported
2010-06-26 20:54 [Qemu-devel] [PATCH] Don't declare XSAVE as supported Andi Kleen
@ 2010-07-01 23:56 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-07-01 23:56 UTC (permalink / raw)
To: Andi Kleen; +Cc: andre.przywara, qemu-devel
On Sat, Jun 26, 2010 at 10:54:21PM +0200, Andi Kleen wrote:
> Don't declare XSAVE as supported
>
> i386 cpuid.c currently claims XSAVE is supported in the CPUID filter,
> but that's not true: Only FXSAVE is supported. Remove that bit
> from the filter.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Thanks, applied.
> diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> index 6a0f7ca..4251a29 100644
> --- a/target-i386/cpuid.c
> +++ b/target-i386/cpuid.c
> @@ -241,11 +241,11 @@ typedef struct x86_def_t {
> /* missing:
> CPUID_VME, CPUID_DTS, CPUID_SS, CPUID_HT, CPUID_TM, CPUID_PBE */
> #define TCG_EXT_FEATURES (CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | \
> - CPUID_EXT_CX16 | CPUID_EXT_POPCNT | CPUID_EXT_XSAVE | \
> + CPUID_EXT_CX16 | CPUID_EXT_POPCNT | \
> CPUID_EXT_HYPERVISOR)
> /* missing:
> CPUID_EXT_DTES64, CPUID_EXT_DSCPL, CPUID_EXT_VMX, CPUID_EXT_EST,
> - CPUID_EXT_TM2, CPUID_EXT_XTPR, CPUID_EXT_PDCM */
> + CPUID_EXT_TM2, CPUID_EXT_XTPR, CPUID_EXT_PDCM, CPUID_EXT_XSAVE */
> #define TCG_EXT2_FEATURES ((TCG_FEATURES & EXT2_FEATURE_MASK) | \
> CPUID_EXT2_NX | CPUID_EXT2_MMXEXT | CPUID_EXT2_RDTSCP | \
> CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT)
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-01 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-26 20:54 [Qemu-devel] [PATCH] Don't declare XSAVE as supported Andi Kleen
2010-07-01 23:56 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).