From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45107 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OTMMO-0001an-Oe
	for qemu-devel@nongnu.org; Mon, 28 Jun 2010 17:59:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OTMML-00081e-2Z
	for qemu-devel@nongnu.org; Mon, 28 Jun 2010 17:59:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61103)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OTMMK-00081Y-Qu
	for qemu-devel@nongnu.org; Mon, 28 Jun 2010 17:59:21 -0400
Date: Mon, 28 Jun 2010 18:59:10 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100628185910.313996cc@redhat.com>
In-Reply-To: <1277307603-28960-4-git-send-email-miguel.filho@gmail.com>
References: <1277307603-28960-1-git-send-email-miguel.filho@gmail.com>
	<1277307603-28960-4-git-send-email-miguel.filho@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/7] net: Introduce
	VLANClientState->info_dict
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Wed, 23 Jun 2010 12:39:59 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> There is no standard format when formatting VLANClientState.info_str,
> so it is difficult to extract information and transmit it over QMP.
> 
> This patch adds info_dict, a QDict to better handle this information.
> 
> Signed-off-by: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
> ---
>  net.c |    1 +
>  net.h |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/net.c b/net.c
> index 0703698..7daf253 100644
> --- a/net.c
> +++ b/net.c
> @@ -301,6 +301,7 @@ void qemu_del_vlan_client(VLANClientState *vc)
>  
>      qemu_free(vc->name);
>      qemu_free(vc->model);
> +    qemu_free(vc->info_dict);

QDECREF(vc->info_dict);

>      qemu_free(vc);
>  }
>  
> diff --git a/net.h b/net.h
> index 518cf9c..cfe837f 100644
> --- a/net.h
> +++ b/net.h
> @@ -65,6 +65,7 @@ struct VLANClientState {
>      char *model;
>      char *name;
>      char info_str[256];
> +    QDict *info_dict;
>      unsigned receive_disabled : 1;
>  };
>