From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47479 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTMP4-0003I8-MA for qemu-devel@nongnu.org; Mon, 28 Jun 2010 18:02:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OTMOx-0008Ov-Ch for qemu-devel@nongnu.org; Mon, 28 Jun 2010 18:02:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3107) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OTMOx-0008Om-5W for qemu-devel@nongnu.org; Mon, 28 Jun 2010 18:02:03 -0400 Date: Mon, 28 Jun 2010 19:01:49 -0300 From: Luiz Capitulino Message-ID: <20100628190149.46f9c1f3@redhat.com> In-Reply-To: <1277307603-28960-1-git-send-email-miguel.filho@gmail.com> References: <1277307603-28960-1-git-send-email-miguel.filho@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/7] QMP: Introduce query-netdev List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Wed, 23 Jun 2010 12:39:56 -0300 Miguel Di Ciurcio Filho wrote: > This series implement the previously discussed QMP command query-netdev. > > There is small change in the specification from the last version: when "type" is > "tap", the attribute "sndbuf" have been removed. "sndbuf" is not available on > all platforms and most of the tap_set_sndbuf() implementations are stubs. Apart from the two bugs I found, looks good to me. My only remaining question is: isn't socket a backend?