From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38571 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTKxm-0000ZN-Ou for qemu-devel@nongnu.org; Mon, 28 Jun 2010 16:30:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OTKxX-00058E-Dl for qemu-devel@nongnu.org; Mon, 28 Jun 2010 16:29:44 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:59257) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OTKxX-000580-61 for qemu-devel@nongnu.org; Mon, 28 Jun 2010 16:29:39 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable Date: Mon, 28 Jun 2010 21:29:33 +0100 References: <1277745445-30560-1-git-send-email-pbonzini@redhat.com> <1277745445-30560-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1277745445-30560-5-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201006282129.34080.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, Paolo Bonzini > diff --git a/exec-all.h b/exec-all.h > index a775582..ebe88ad 100644 > --- a/exec-all.h > +++ b/exec-all.h > @@ -353,4 +353,8 @@ extern int singlestep; > /* cpu-exec.c */ > extern volatile sig_atomic_t exit_request; > > +#ifdef NEED_GLOBAL_ENV > +register CPUState *env asm(AREG0); > +#endif Wouldn't it be better to just put this in dyngen-exec.h ? AFAICT there's a direct correlation between NEED_GLOBAL_ENV and #include "exec.h". Paul