* [Qemu-devel] [PATCH] virtio-9p: Fix the memset usage
@ 2010-06-30 4:45 Aneesh Kumar K.V
2010-06-30 5:15 ` Sripathi Kodi
0 siblings, 1 reply; 2+ messages in thread
From: Aneesh Kumar K.V @ 2010-06-30 4:45 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori, Aneesh Kumar K.V
The arguments are wrong. Use qemu_mallocz directly
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
hw/virtio-9p.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index 5c5a34b..fba6619 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -2782,8 +2782,7 @@ static void v9fs_wstat_post_chown(V9fsState *s, V9fsWstatState *vs, int err)
if (vs->v9stat.name.size != 0) {
V9fsRenameState *vr;
- vr = qemu_malloc(sizeof(V9fsRenameState));
- memset(vr, sizeof(*vr), 0);
+ vr = qemu_mallocz(sizeof(V9fsRenameState));
vr->newdirfid= -1;
vr->pdu = vs->pdu;
vr->fidp = vs->fidp;
--
1.7.2.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix the memset usage
2010-06-30 4:45 [Qemu-devel] [PATCH] virtio-9p: Fix the memset usage Aneesh Kumar K.V
@ 2010-06-30 5:15 ` Sripathi Kodi
0 siblings, 0 replies; 2+ messages in thread
From: Sripathi Kodi @ 2010-06-30 5:15 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: aliguori, qemu-devel
On Wed, 30 Jun 2010 10:15:29 +0530
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> The arguments are wrong. Use qemu_mallocz directly
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Reviewed-by: Sripathi Kodi <sripathik@in.ibm.com>
> ---
> hw/virtio-9p.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
> index 5c5a34b..fba6619 100644
> --- a/hw/virtio-9p.c
> +++ b/hw/virtio-9p.c
> @@ -2782,8 +2782,7 @@ static void v9fs_wstat_post_chown(V9fsState *s, V9fsWstatState *vs, int err)
> if (vs->v9stat.name.size != 0) {
> V9fsRenameState *vr;
>
> - vr = qemu_malloc(sizeof(V9fsRenameState));
> - memset(vr, sizeof(*vr), 0);
> + vr = qemu_mallocz(sizeof(V9fsRenameState));
> vr->newdirfid= -1;
> vr->pdu = vs->pdu;
> vr->fidp = vs->fidp;
> --
> 1.7.2.rc0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-30 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-30 4:45 [Qemu-devel] [PATCH] virtio-9p: Fix the memset usage Aneesh Kumar K.V
2010-06-30 5:15 ` Sripathi Kodi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).