From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48000 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OULx7-0004lj-6g for qemu-devel@nongnu.org; Thu, 01 Jul 2010 11:45:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OULx5-0003It-AK for qemu-devel@nongnu.org; Thu, 01 Jul 2010 11:45:24 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:41092) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OULx5-0003IU-1f for qemu-devel@nongnu.org; Thu, 01 Jul 2010 11:45:23 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups Date: Thu, 1 Jul 2010 16:45:17 +0100 References: <20100629211802.16137.10587.malonedeb@soybean.canonical.com> <4C2C402C.9040502@web.de> <20100701081929.GA30428@redhat.com> In-Reply-To: <20100701081929.GA30428@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007011645.18184.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bug 599958 <599958@bugs.launchpad.net>, Jan Kiszka , Gleb Natapov > Since it solves existing problem and is rejected without any rational > explanation and without proposing alternative solution (in form of code) > it should be committed. No. This is not sufficient justification for applying a patch. We should not be accepting patches just because they exist. If a feature[1] is important enough that we need to implement it, then it should also warrant getting a good solution. Otherwise we're going to end up in exactly the same situation next time someone starts using a nwew timesource. Paul [1] Time-drift hacks are a new *feature*, not a bugfix. At best they're hiding more fundamental flaws, e.g. kvm being incapable of emulating realtime behavior.