From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42150 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVkfG-0002Uc-3c for qemu-devel@nongnu.org; Mon, 05 Jul 2010 08:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVkfF-0007FP-3m for qemu-devel@nongnu.org; Mon, 05 Jul 2010 08:20:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47550) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVkfE-0007FH-TB for qemu-devel@nongnu.org; Mon, 05 Jul 2010 08:20:45 -0400 Date: Mon, 5 Jul 2010 15:20:25 +0300 From: Gleb Natapov Subject: Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups Message-ID: <20100705122025.GQ4689@redhat.com> References: <20100705064239.GI4689@redhat.com> <4C31807B.2030401@web.de> <20100705070017.GJ4689@redhat.com> <4C318B74.3040403@web.de> <4C319C30.30308@redhat.com> <4C31A0EC.7020803@web.de> <4C31A477.7010205@redhat.com> <4C31BE6A.70307@siemens.com> <4C31C4A3.4070208@redhat.com> <4C31CD38.5050904@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C31CD38.5050904@siemens.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , "qemu-devel@nongnu.org" , Avi Kivity , Paul Brook On Mon, Jul 05, 2010 at 02:16:56PM +0200, Jan Kiszka wrote: > Avi Kivity wrote: > > On 07/05/2010 02:13 PM, Jan Kiszka wrote: > >> That decoupling between state change and acknowledgment worries me. > >> Dispatching a source to multiple sinks or sharing a sink between > >> multiple source is no longer cleanly manageable this way. Just look at > >> the route of some ISA IRQ on x86: You may get an 'ack' from IOAPIC side > >> and a 'masked' from the ISA side (or vice versa). And the 'masked' will > >> arrive earlier. > > > > I think it is sufficient to only note masks and take action on acks. > > We would increment our backlog on injection, decrement it on mask > notification - and decrement it again on ack. > On mask notification backlog is zeroed and not incremented until unmask notification. -- Gleb.