From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36455 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWBH9-0006D6-15 for qemu-devel@nongnu.org; Tue, 06 Jul 2010 12:45:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWBGy-0003ig-JR for qemu-devel@nongnu.org; Tue, 06 Jul 2010 12:45:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58942) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWBGy-0003iF-Co for qemu-devel@nongnu.org; Tue, 06 Jul 2010 12:45:28 -0400 Date: Tue, 6 Jul 2010 17:45:13 +0100 From: "Daniel P. Berrange" Message-ID: <20100706164513.GB5596@redhat.com> References: <1278419869-26126-1-git-send-email-armbru@redhat.com> <1278419869-26126-5-git-send-email-armbru@redhat.com> <4C335C59.3030801@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C335C59.3030801@redhat.com> Subject: [Qemu-devel] Re: [PATCH 4/8] block QMP: Drop query-block member "type" (type= in info block) Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: hch@lst.de, kraxel@redhat.com, Markus Armbruster , qemu-devel@nongnu.org On Tue, Jul 06, 2010 at 06:39:53PM +0200, Kevin Wolf wrote: > Am 06.07.2010 14:37, schrieb Markus Armbruster: > > Its value is unreliable: a block device used as floppy has type > > "floppy" if created with if=floppy, but type "hd" if created with > > if=none. > > > > That's because with if=none, the type is at best a declaration of > > intent: the drive can be connected to any guest device. Its type is > > really the guest device's business. Reporting it here is wrong. > > > > Signed-off-by: Markus Armbruster > > Dan, I'd like to have your Acked-by for this patch before applying it. > Can libvirt handle such a change in the monitor output, or does it even > use info block? We don't use the 'info block' or query-block commands at this point in time, only 'info blockstats'/'query-blockstats'. So it should be fine to drop this field from libvirt's POV. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|