From: Christoph Hellwig <hch@lst.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: [Qemu-devel] Re: [PATCH v2 06/13] scsi: Reject unimplemented error actions
Date: Wed, 7 Jul 2010 03:26:09 +0200 [thread overview]
Message-ID: <20100707012609.GF2398@lst.de> (raw)
In-Reply-To: <1278418136-24556-7-git-send-email-armbru@redhat.com>
On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote:
> drive_init() doesn't permit rerror for if=scsi, but that's worthless:
> we get it via if=none and -device.
>
> Moreover, scsi-generic doesn't support werror. Since drive_init()
> doesn't catch that, option werror was silently ignored even with
> if=scsi.
>
> Wart: unlike drive_init(), we don't reject the default action when
> it's explicitly specified. That's because we can't distinguish "no
> rerror option" from "rerror=report", or "no werror" from
> "rerror=enospc". Left for another day.
I can't see a good reason that scsi doesn't support the rerror option,
and implementing is trivial. So while this patch looks correct I'd
rather see rerror implemented for scsi than hacking around the lack of
it.
next prev parent reply other threads:[~2010-07-07 1:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 12:08 [Qemu-devel] [PATCH v2 00/13] Still more block related fixes and cleanups Markus Armbruster
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 01/13] blockdev: Clean up how readonly persists across virtual media change Markus Armbruster
2010-07-07 1:19 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 02/13] block migration: Fix test for read-only drive Markus Armbruster
2010-07-07 1:19 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 03/13] raw-posix: Fix test for host CD-ROM Markus Armbruster
2010-07-07 1:23 ` [Qemu-devel] " Christoph Hellwig
2010-07-07 9:34 ` Markus Armbruster
2010-07-07 10:06 ` Kevin Wolf
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 04/13] fdc: Reject unimplemented error actions Markus Armbruster
2010-07-07 1:23 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 05/13] qdev: Don't hw_error() in qdev_init_nofail() Markus Armbruster
2010-07-07 1:24 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 06/13] scsi: Reject unimplemented error actions Markus Armbruster
2010-07-07 1:26 ` Christoph Hellwig [this message]
2010-07-07 9:41 ` [Qemu-devel] " Markus Armbruster
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 07/13] error: New qemu_opts_loc_restore() Markus Armbruster
2010-07-07 1:26 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 08/13] scsi: Error locations for -drive if=scsi device initialization Markus Armbruster
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 09/13] ide: Improve error messages Markus Armbruster
2010-07-07 1:26 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 10/13] ide: Replace IDEState members is_cdrom, is_cf by drive_kind Markus Armbruster
2010-07-07 1:27 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 11/13] ide: Make ide_init_drive() return success Markus Armbruster
2010-07-07 1:28 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 12/13] ide: Reject readonly drives unless CD-ROM Markus Armbruster
2010-07-07 1:28 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 13/13] ide: Reject invalid CHS geometry Markus Armbruster
2010-07-07 1:28 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 14:06 ` [Qemu-devel] Re: [PATCH v2 00/13] Still more block related fixes and cleanups Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707012609.GF2398@lst.de \
--to=hch@lst.de \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).