From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36038 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWJZP-0007MO-9v for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWJZO-000126-1S for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:37:03 -0400 Received: from verein.lst.de ([213.95.11.210]:39084) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWJZN-00011z-O1 for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:37:02 -0400 Date: Wed, 7 Jul 2010 03:37:00 +0200 From: Christoph Hellwig Message-ID: <20100707013700.GF3073@lst.de> References: <1278419869-26126-1-git-send-email-armbru@redhat.com> <1278419869-26126-7-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278419869-26126-7-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] Re: [PATCH 6/8] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com On Tue, Jul 06, 2010 at 02:37:47PM +0200, Markus Armbruster wrote: > Disk vs. CD needs to be in qdev, because it belongs to the drive's > guest part. Looks good, but the scsi-hd name feelds kinda awkward. This is one case we're I'm really wondering if the compatiblity is worth it or if we should just keep using scsi-disk for the real disk. Reviewed-by: Christoph Hellwig