From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49721 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWKM2-0007R8-73
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 22:27:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kevin@koconnor.net>) id 1OWKLy-0001fP-G7
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 22:27:18 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:50606)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kevin@koconnor.net>) id 1OWKLy-0001e0-DY
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 22:27:14 -0400
Received: by vws2 with SMTP id 2so1570215vws.4
	for <qemu-devel@nongnu.org>; Tue, 06 Jul 2010 19:27:12 -0700 (PDT)
Date: Tue, 6 Jul 2010 22:27:09 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20100707022709.GA27532@morn.localdomain>
References: <cover.1278296294.git.yamahata@valinux.co.jp>
	<177358e2b54ffc6e9063abbb2d5fcb8e4ad88d52.1278296294.git.yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <177358e2b54ffc6e9063abbb2d5fcb8e4ad88d52.1278296294.git.yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 2/2] seabios: pciinit: use pci
 device initializer helper function.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

On Mon, Jul 05, 2010 at 11:22:29AM +0900, Isaku Yamahata wrote:
> This patch makes use of pci device initialization helper function
> to convert if/switch clause to table driven.
> So this makes it easier to add q35 initialization code.

Looks okay to me.  A couple of minor comments..

>  SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c coreboot.c boot.c \
>        acpi.c smm.c mptable.c smbios.c pciinit.c optionroms.c mtrr.c \
> -      lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c
> +      lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c i440fx.c

The "i440fx.c" is a bit cryptic for someone unfamiliar with the hardware.
Maybe "dev-i440fx.c" or something similar?

> +++ b/src/i440fx.h
> @@ -0,0 +1,17 @@
> +// initialization function which are specific to i440fx chipset
> +//
> +// Copyright (C) 2008  Kevin O'Connor <kevin@koconnor.net>
> +// Copyright (C) 2006 Fabrice Bellard
> +//
> +// Copyright (C) 2010 Isaku Yamahata <yamahata at valinux co jp>
> +// Split out from pciinit.c
> +//
> +// This file may be distributed under the terms of the GNU LGPLv3 license.
> +#ifndef __I440FX_H
> +#define __I440FX_H
> +
> +void piix_isa_bridge_init(u16 bdf, void *arg);
> +void piix_ide_init(u16 bdf, void *arg);
> +void piix4_pm_init(u16 bdf, void *arg);
> +
> +#endif // __I440FX_H

I would prefer not to add long copyright statements on function
prototypes.  Lets copyright the code, not the headers.

-Kevin