From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43960 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWULS-0000WR-2N
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 09:07:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OWULR-0002fM-3k
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 09:07:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5612)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OWULQ-0002f6-Qv
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 09:07:21 -0400
Date: Wed, 7 Jul 2010 10:07:09 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100707100709.27a9a9e7@redhat.com>
In-Reply-To: <AANLkTim9xU28c6FcgDvXoPN352ntG8UwxpkVQX8Ak7Jy@mail.gmail.com>
References: <1278106023-9966-1-git-send-email-miguel.filho@gmail.com>
	<1278106023-9966-2-git-send-email-miguel.filho@gmail.com>
	<20100705122253.5d771107@redhat.com>
	<AANLkTim9xU28c6FcgDvXoPN352ntG8UwxpkVQX8Ak7Jy@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] QMP: Introduce the documentation for
	query-qdm
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Mon, 5 Jul 2010 16:34:22 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> Possible values for "type" are defined in the patch on the
> qdev_property_type_to_string() function. To spot them in the current
> code, hw/qdev.c:77:
> 
> enum PropertyType {
>     PROP_TYPE_UNSPEC = 0,
>     PROP_TYPE_UINT8,
>     PROP_TYPE_UINT16,
>     PROP_TYPE_UINT32,
>     PROP_TYPE_INT32,
>     PROP_TYPE_UINT64,
>     PROP_TYPE_TADDR,
>     PROP_TYPE_MACADDR,
>     PROP_TYPE_DRIVE,
>     PROP_TYPE_CHR,
>     PROP_TYPE_STRING,
>     PROP_TYPE_NETDEV,
>     PROP_TYPE_VLAN,
>     PROP_TYPE_PTR,
>     PROP_TYPE_BIT,
> };
> 
> So it is a mix of json-(string|integer|boolean). It seams to me that a
> device_add using QMP will use just use strings. Need to confirm that.

There are integers too.

Daniel, can you clarify how libvirt is going to use this member?

Maybe we could have something like this:

 "type": { "qdev": "macaddr", "qmp": "string" }