From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>,
Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] set proper migration status on ->write error
Date: Wed, 7 Jul 2010 15:04:11 -0300 [thread overview]
Message-ID: <20100707180411.GA17569@amt.cnet> (raw)
If ->write fails, declare migration status as MIG_STATE_ERROR.
Also, in buffered_file.c, ->close the object in case of an
error.
Fixes "migrate -d "exec:dd of=file", where dd fails to open file.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/buffered_file.c b/buffered_file.c
index 54dc6c2..be147d6 100644
--- a/buffered_file.c
+++ b/buffered_file.c
@@ -222,8 +222,10 @@ static void buffered_rate_tick(void *opaque)
{
QEMUFileBuffered *s = opaque;
- if (s->has_error)
+ if (s->has_error) {
+ buffered_close(s);
return;
+ }
qemu_mod_timer(s->timer, qemu_get_clock(rt_clock) + 100);
diff --git a/migration.c b/migration.c
index b49964c..5bf2f4e 100644
--- a/migration.c
+++ b/migration.c
@@ -318,6 +318,8 @@ ssize_t migrate_fd_put_buffer(void *opaque, const void *data, size_t size)
if (ret == -EAGAIN)
qemu_set_fd_handler2(s->fd, NULL, NULL, migrate_fd_put_notify, s);
+ else
+ s->state = MIG_STATE_ERROR;
return ret;
}
next reply other threads:[~2010-07-07 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 18:04 Marcelo Tosatti [this message]
2010-07-07 18:14 ` [Qemu-devel] [PATCH] set proper migration status on ->write error Blue Swirl
2010-07-07 19:42 ` [Qemu-devel] [PATCH] set proper migration status on ->write error (v2) Marcelo Tosatti
2010-07-07 23:17 ` [Qemu-devel] " Juan Quintela
2010-07-07 18:37 ` [Qemu-devel] Re: [PATCH] set proper migration status on ->write error Juan Quintela
2010-07-09 18:18 ` [Qemu-devel] [PATCH] set proper migration status on ->write error (v3) Marcelo Tosatti
2010-07-13 1:33 ` [Qemu-devel] " Luiz Capitulino
2010-07-13 17:30 ` [Qemu-devel] [PATCH] set proper migration status on ->write error (v4) Marcelo Tosatti
2010-07-13 22:35 ` [Qemu-devel] " Luiz Capitulino
2010-07-14 0:01 ` [Qemu-devel] [PATCH] set proper migration status on ->write error (v5) Marcelo Tosatti
2010-07-14 16:39 ` [Qemu-devel] " Luiz Capitulino
2010-07-14 17:30 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707180411.GA17569@amt.cnet \
--to=mtosatti@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).