From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41842 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWr0Z-0002K1-I9 for qemu-devel@nongnu.org; Thu, 08 Jul 2010 09:19:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWr0Q-0006J2-7D for qemu-devel@nongnu.org; Thu, 08 Jul 2010 09:19:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57048) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWr0P-0006Iu-SX for qemu-devel@nongnu.org; Thu, 08 Jul 2010 09:19:10 -0400 Date: Thu, 8 Jul 2010 14:19:01 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH v2 08/18] vnc: tight add PNG encoding Message-ID: <20100708131901.GH32528@redhat.com> References: <1278529086-10391-1-git-send-email-corentincj@iksaif.net> <1278529086-10391-9-git-send-email-corentincj@iksaif.net> <20100708094805.GC32528@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corentin Chary Cc: Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf On Thu, Jul 08, 2010 at 03:10:31PM +0200, Corentin Chary wrote: > On Thu, Jul 8, 2010 at 11:48 AM, Daniel P. Berrange wrote: > > On Wed, Jul 07, 2010 at 08:57:56PM +0200, Corentin Chary wrote: > >> Introduce a new encoding: VNC_ENCODING_TIGHT_PNG [1] (-269) with a new > >> tight filter VNC_TIGHT_PNG (0x0A). When the client tells it supports the Tight PNG > >> encoding, the server will use tight, but will always send encoding pixels using > >> PNG instead of zlib. If the client also told it support JPEG, then the server can > >> send JPEG, because PNG will only be used in the cases zlib was used in normal tight. > > > > I know that VNC_ENCODING_TIGHT_PNG / -260 is already allocated to > > QEMU in the RFB specification. Who is the authority for allocating > > tight filter numbers, and have they recorded/approved use of 0x0A > > for this PNG capability ? > > > > Tight PNG should considered as a new encoding, not as a tight pseudo encoding. > When using Tight PNG, the server will send rect updates with -260, not 7. Why layer this into the rest of the Tight protocol decoding then ? What benefit does it offer over a more straightforward standalone "PNG" encoding, that was completely independant of any tight based encoding. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|