From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33874 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OX2i3-0005Bp-Jl for qemu-devel@nongnu.org; Thu, 08 Jul 2010 21:49:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OX2i2-0007SS-EK for qemu-devel@nongnu.org; Thu, 08 Jul 2010 21:48:59 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:58255) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OX2i1-0007SC-Uk for qemu-devel@nongnu.org; Thu, 08 Jul 2010 21:48:58 -0400 Date: Fri, 9 Jul 2010 10:44:55 +0900 From: Isaku Yamahata Subject: Re: [Qemu-devel] [PATCH v5 0/9] pci: multi-function bit fixes Message-ID: <20100709014455.GA22818@valinux.co.jp> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, yu.liu@freescale.com, paul@codesourcery.com, aurelien@aurel32.net, mst@redhat.com Ping? Since this is bug fix patches, I'd like to include them into the next release. On Wed, Jun 23, 2010 at 04:15:24PM +0900, Isaku Yamahata wrote: > Maing changes v4 -> v5: > - split up/reorder patches for bisectability and testability > - stype fixes. > > patch description: > > When pci devices are populated as multi-function, > OS can fail to probe function > 0. It's because multi function > bit of header type register in configuration space isn't set, > so OS probes only function 0 skipping function > 0 as optimization. > > This patch set make qemu set multi function bit when function > 0 > is populated. > > Changes v3 -> v4: > - introduced multifunction property and add validation check to catch > user operation errors. > - some more clean up. > > > Isaku Yamahata (9): > pci: use PCI_DEVFN() where appropriate. > pci: insert assert that auto-assigned-address function is single > function device. > pci: don't overwrite multi functio bit in pci header type. > pci: remove PCIDeviceInfo::header_type > qdev: implement qdev_prop_set_bit(). > pci: introduce multifunction property. > pci: set multifunction property for normal device. > pci_bridge: make pci bridge aware of pci multi function bit. > pci: set PCI multi-function bit appropriately. > > hw/ac97.c | 1 - > hw/acpi_piix4.c | 1 - > hw/apb_pci.c | 11 ++---- > hw/dec_pci.c | 4 +- > hw/grackle_pci.c | 1 - > hw/gt64xxx.c | 2 +- > hw/ide/cmd646.c | 1 - > hw/ide/piix.c | 1 - > hw/macio.c | 1 - > hw/ne2000.c | 1 - > hw/openpic.c | 1 - > hw/pci.c | 97 +++++++++++++++++++++++++++++++++++++++++++------- > hw/pci.h | 21 +++++++++-- > hw/pcnet.c | 1 - > hw/piix4.c | 4 +-- > hw/piix_pci.c | 5 +-- > hw/ppce500_pci.c | 3 +- > hw/prep_pci.c | 1 - > hw/qdev-properties.c | 5 +++ > hw/qdev.h | 1 + > hw/rtl8139.c | 1 - > hw/sun4u.c | 1 - > hw/unin_pci.c | 16 +++----- > hw/usb-uhci.c | 1 - > hw/versatile_pci.c | 2 +- > hw/vga-pci.c | 1 - > hw/virtio-pci.c | 1 - > hw/vmware_vga.c | 1 - > hw/wdt_i6300esb.c | 1 - > 29 files changed, 125 insertions(+), 63 deletions(-) > > -- yamahata