* [Qemu-devel] [PATCH] pci: fix pci_unregister_secondary_bus().
@ 2010-07-09 1:52 Isaku Yamahata
2010-07-09 6:46 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Isaku Yamahata @ 2010-07-09 1:52 UTC (permalink / raw)
To: qemu-devel; +Cc: yamahata, mst
Fix leak in pci_unregister_secondary_bus().
call qbus_free().
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
hw/pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index a7ff566..25634ed 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -298,6 +298,7 @@ static void pci_unregister_secondary_bus(PCIBus *bus)
{
assert(QLIST_EMPTY(&bus->child));
QLIST_REMOVE(bus, sibling);
+ qbus_free(&bus->qbus);
}
int pci_bus_num(PCIBus *s)
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pci: fix pci_unregister_secondary_bus().
2010-07-09 1:52 [Qemu-devel] [PATCH] pci: fix pci_unregister_secondary_bus() Isaku Yamahata
@ 2010-07-09 6:46 ` Markus Armbruster
2010-07-09 7:02 ` Isaku Yamahata
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2010-07-09 6:46 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: qemu-devel, mst
Isaku Yamahata <yamahata@valinux.co.jp> writes:
> Fix leak in pci_unregister_secondary_bus().
> call qbus_free().
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
> hw/pci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index a7ff566..25634ed 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -298,6 +298,7 @@ static void pci_unregister_secondary_bus(PCIBus *bus)
> {
> assert(QLIST_EMPTY(&bus->child));
> QLIST_REMOVE(bus, sibling);
> + qbus_free(&bus->qbus);
> }
>
> int pci_bus_num(PCIBus *s)
Buses are normally freed automatically along with the device providing
them, in qdev_free(). Why is that not sufficient for pci-bridge?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pci: fix pci_unregister_secondary_bus().
2010-07-09 6:46 ` Markus Armbruster
@ 2010-07-09 7:02 ` Isaku Yamahata
0 siblings, 0 replies; 3+ messages in thread
From: Isaku Yamahata @ 2010-07-09 7:02 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, mst
On Fri, Jul 09, 2010 at 08:46:33AM +0200, Markus Armbruster wrote:
> Isaku Yamahata <yamahata@valinux.co.jp> writes:
>
> > Fix leak in pci_unregister_secondary_bus().
> > call qbus_free().
> >
> > Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> > ---
> > hw/pci.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/pci.c b/hw/pci.c
> > index a7ff566..25634ed 100644
> > --- a/hw/pci.c
> > +++ b/hw/pci.c
> > @@ -298,6 +298,7 @@ static void pci_unregister_secondary_bus(PCIBus *bus)
> > {
> > assert(QLIST_EMPTY(&bus->child));
> > QLIST_REMOVE(bus, sibling);
> > + qbus_free(&bus->qbus);
> > }
> >
> > int pci_bus_num(PCIBus *s)
>
> Buses are normally freed automatically along with the device providing
> them, in qdev_free(). Why is that not sufficient for pci-bridge?
>
Right. I withdraw this patch.
Sorry for noise.
--
yamahata
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-09 7:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-09 1:52 [Qemu-devel] [PATCH] pci: fix pci_unregister_secondary_bus() Isaku Yamahata
2010-07-09 6:46 ` Markus Armbruster
2010-07-09 7:02 ` Isaku Yamahata
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).