From: Kevin O'Connor <kevin@koconnor.net>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH v2 2/2] seabios: pciinit: use pci device initializer helper function.
Date: Sat, 10 Jul 2010 13:14:06 -0400 [thread overview]
Message-ID: <20100710171406.GA20136@morn.localdomain> (raw)
In-Reply-To: <739f747793eff3dbe14f225f5415c61a36d7ab03.1278472308.git.yamahata@valinux.co.jp>
On Wed, Jul 07, 2010 at 12:14:02PM +0900, Isaku Yamahata wrote:
> This patch makes use of pci device initialization helper function
> to convert if/switch clause to table driven.
> So this makes it easier to add q35 initialization code.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
I committed the first patch. I committed the second patch after
fixing up the compile on it.
You're likely seeing " Working around non-functional -combine" printed
during the build. When in this mode the build textually includes all
the .c files in order to still take advantage of the -fwhole-program
optimization. Unfortunately in this mode, improper includes can slip
through.
You might want to try grabbing a newer version of gcc. I believe both
the latest gcc v4.4 and gcc v4.5 work correctly.
-Kevin
next prev parent reply other threads:[~2010-07-10 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 3:14 [Qemu-devel] [PATCH v2 0/2] seabios: pci: pci initialization clean up Isaku Yamahata
2010-07-07 3:14 ` [Qemu-devel] [PATCH v2 1/2] seabios: pci: introduce helper function to initialize a given device Isaku Yamahata
2010-07-07 3:14 ` [Qemu-devel] [PATCH v2 2/2] seabios: pciinit: use pci device initializer helper function Isaku Yamahata
2010-07-10 17:14 ` Kevin O'Connor [this message]
2010-07-11 2:52 ` [Qemu-devel] Re: [SeaBIOS] " Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100710171406.GA20136@morn.localdomain \
--to=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).