[Qemu-devel] Re: [SeaBIOS] [PATCH v2 2/2] seabios: pciinit: use pci device initializer helper function.

[Isaku Yamahata <yamahata@valinux.co.jp>]

On Sat, Jul 10, 2010 at 01:14:06PM -0400, Kevin O'Connor wrote:
> On Wed, Jul 07, 2010 at 12:14:02PM +0900, Isaku Yamahata wrote:
> > This patch makes use of pci device initialization helper function
> > to convert if/switch clause to table driven.
> > So this makes it easier to add q35 initialization code.
> > 
> > Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> I committed the first patch.  I committed the second patch after
> fixing up the compile on it.

Thank you for fixing the patch.


> You're likely seeing " Working around non-functional -combine" printed
> during the build.  When in this mode the build textually includes all
> the .c files in order to still take advantage of the -fwhole-program
> optimization.  Unfortunately in this mode, improper includes can slip
> through.
> 
> You might want to try grabbing a newer version of gcc.  I believe both
> the latest gcc v4.4 and gcc v4.5 work correctly.

Yes, the message was printed out.
I've upgraded gcc from v4.3.4 to v4.4.4 and confirmed the error.
Future patches will be tested with gcc v4.4.
-- 
yamahata