From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39751 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OYHvt-0006Yv-66
	for qemu-devel@nongnu.org; Mon, 12 Jul 2010 08:16:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OYHvq-0004Rc-Qu
	for qemu-devel@nongnu.org; Mon, 12 Jul 2010 08:16:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20861)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OYHvq-0004RU-KR
	for qemu-devel@nongnu.org; Mon, 12 Jul 2010 08:16:22 -0400
Date: Mon, 12 Jul 2010 15:11:07 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100712121107.GB31649@redhat.com>
References: <cover.1278930415.git.yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1278930415.git.yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH v2 0/5] pci: split out bridge code into
 pci_bridge and make it library
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org

On Mon, Jul 12, 2010 at 07:36:39PM +0900, Isaku Yamahata wrote:
> changes v1 -> v2:
> - introduce pci_internals.h to accomodate pci internal strcutures to
>   share between pci.c and pci_bridge.c
> - don't make PCIBridge::bus pointer as suggested by
>   Michael S. Tsirkin <mst@redhat.com>
> - rename PCIBridge::bus -> PCIBridge::sec_bus
> - eliminate pci_reguster_secondary_bus()/pci_unregister_secondary_bus()
> - document pci bridge library functions.
> - introduced pci bridge library.

I've applied patches 1-4 to make it easier to build upon.
Pushed in pci branch in my tree.
Sent comments on patch 5.

> Clean up of pci host bus ans piix pci as discussed with v1
> will be addressed after this patch set is accepted.
> 
> Patch description:
> Now pci.c has grown. So split bridge related code into dedicated file
> for further extension to pci bridge. Further clean up and pcie port emulator. 
> This make patch conflict less possible in future.
> 
> Isaku Yamahata (5):
>   pci: move out pci internal structures, PCIBus, PCIBridge, and
>     pci_bus_info.
>   pci/bridge: split out pci bridge code into pci_bridge.c from pci.c
>   pci_bridge: rename PCIBridge::bus -> PCIBridge::sec_bus.
>   pci_bridge: clean up: remove pci_{register,
>     unregister}_secondary_bus()
>   pci_bridge: introduce pci bridge library.
> 
>  Makefile.objs      |    2 +-
>  hw/apb_pci.c       |   43 ++++++---
>  hw/dec_pci.c       |   35 ++++++--
>  hw/pci.c           |  207 +------------------------------------------
>  hw/pci.h           |    5 +-
>  hw/pci_bridge.c    |  249 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/pci_bridge.h    |   62 +++++++++++++
>  hw/pci_internals.h |   42 +++++++++
>  qemu-common.h      |    1 +
>  9 files changed, 416 insertions(+), 230 deletions(-)
>  create mode 100644 hw/pci_bridge.c
>  create mode 100644 hw/pci_bridge.h
>  create mode 100644 hw/pci_internals.h