From: Kevin O'Connor <kevin@koconnor.net>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 6/7] seabios: acpi: split out piix4 pm logic.
Date: Mon, 12 Jul 2010 21:02:39 -0400 [thread overview]
Message-ID: <20100713010239.GC13722@morn.localdomain> (raw)
In-Reply-To: <1cc6f855e29f3bffdc119f1e07b7da7dbf43f024.1278935094.git.yamahata@valinux.co.jp>
On Mon, Jul 12, 2010 at 08:47:51PM +0900, Isaku Yamahata wrote:
> split out piix4 pm logic.
[...]
> @@ -202,11 +203,6 @@ static inline u16 cpu_to_le16(u16 x)
> return x;
> }
>
> -static inline u32 cpu_to_le32(u32 x)
> -{
> - return x;
> -}
This is a nitpick, but if cpu_to_le32() is moved to a header then
cpu_to_le16() needs to be moved to. It should also be moved to where
ntohl() is defined (util.h).
-Kevin
next prev parent reply other threads:[~2010-07-13 1:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 11:47 [Qemu-devel] [PATCH 0/7] abstract chipset(i440fx) specific register operation Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 1/7] seabios: pci: introduce helper function to find device from table and initialize it Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 2/7] seabios: shadow: make device finding more generic Isaku Yamahata
2010-07-13 0:59 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
2010-07-13 9:45 ` Isaku Yamahata
2010-07-20 3:05 ` Kevin O'Connor
2010-07-12 11:47 ` [Qemu-devel] [PATCH 3/7] seabios: smm: move out piix4 specific logic to dev-i440fx.c Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 4/7] seabios: smm_init: move out i440fx smram operation into dev-i440fx.c Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 5/7] seabios: acpi: move acpi definitions to acpi.h from acpi.c Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 6/7] seabios: acpi: split out piix4 pm logic Isaku Yamahata
2010-07-13 1:02 ` Kevin O'Connor [this message]
2010-07-12 11:47 ` [Qemu-devel] [PATCH 7/7] seabios: acpi: clean up of finding pm device Isaku Yamahata
2010-07-13 0:50 ` [Qemu-devel] Re: [SeaBIOS] [PATCH 0/7] abstract chipset(i440fx) specific register operation Kevin O'Connor
2010-07-13 2:43 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713010239.GC13722@morn.localdomain \
--to=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).