From: Isaku Yamahata <yamahata@valinux.co.jp>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 2/7] seabios: shadow: make device finding more generic.
Date: Tue, 13 Jul 2010 18:45:00 +0900 [thread overview]
Message-ID: <20100713094500.GF31689@valinux.co.jp> (raw)
In-Reply-To: <20100713005914.GB13722@morn.localdomain>
On Mon, Jul 12, 2010 at 08:59:14PM -0400, Kevin O'Connor wrote:
> On Mon, Jul 12, 2010 at 08:47:47PM +0900, Isaku Yamahata wrote:
> > pam register offset is north bridge specific.
> > So determine the offset based on found north bridge.
>
> Is it really just the offset that is north bridge specific? I thought
> the entire process was very north bridge specific.
>
> If so, I don't think it makes sense to pass back the pam0 register -
> instead the north bridge specific code should do the necessary work
> (using helper functions if possible).
>
> I have the same concern with part 3 and 4 of this series.
I440fx and Q35 (all Intel chipset?) are similar in registers
which seabios programs, so I choice to abstract it at register offset level.
I don't expect that other vendor's chipset support is wanted.
If you want more high level abstract, I'll respin the patch set.
--
yamahata
next prev parent reply other threads:[~2010-07-13 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 11:47 [Qemu-devel] [PATCH 0/7] abstract chipset(i440fx) specific register operation Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 1/7] seabios: pci: introduce helper function to find device from table and initialize it Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 2/7] seabios: shadow: make device finding more generic Isaku Yamahata
2010-07-13 0:59 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
2010-07-13 9:45 ` Isaku Yamahata [this message]
2010-07-20 3:05 ` Kevin O'Connor
2010-07-12 11:47 ` [Qemu-devel] [PATCH 3/7] seabios: smm: move out piix4 specific logic to dev-i440fx.c Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 4/7] seabios: smm_init: move out i440fx smram operation into dev-i440fx.c Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 5/7] seabios: acpi: move acpi definitions to acpi.h from acpi.c Isaku Yamahata
2010-07-12 11:47 ` [Qemu-devel] [PATCH 6/7] seabios: acpi: split out piix4 pm logic Isaku Yamahata
2010-07-13 1:02 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
2010-07-12 11:47 ` [Qemu-devel] [PATCH 7/7] seabios: acpi: clean up of finding pm device Isaku Yamahata
2010-07-13 0:50 ` [Qemu-devel] Re: [SeaBIOS] [PATCH 0/7] abstract chipset(i440fx) specific register operation Kevin O'Connor
2010-07-13 2:43 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713094500.GF31689@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).