* [Qemu-devel] [PATCH] kvm: Don't walk memory_size == 0 slots in kvm_client_migration_log
@ 2010-07-14 19:36 Alex Williamson
2010-07-16 1:12 ` [Qemu-devel] " Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Alex Williamson @ 2010-07-14 19:36 UTC (permalink / raw)
To: kvm, qemu-devel; +Cc: mtosatti, avi
If we've unregistered a memory area, we should avoid calling
qemu_get_ram_ptr() on the left over phys_offset cruft in the
slot array. Now that we support removing ramblocks, the
phys_offset ram_addr_t can go away and cause a lookup fault
and abort.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
kvm-all.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index fec6d05..2922292 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -282,6 +282,9 @@ static int kvm_set_migration_log(int enable)
for (i = 0; i < ARRAY_SIZE(s->slots); i++) {
mem = &s->slots[i];
+ if (!mem->memory_size) {
+ continue;
+ }
if (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) {
continue;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] kvm: Don't walk memory_size == 0 slots in kvm_client_migration_log
2010-07-14 19:36 [Qemu-devel] [PATCH] kvm: Don't walk memory_size == 0 slots in kvm_client_migration_log Alex Williamson
@ 2010-07-16 1:12 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2010-07-16 1:12 UTC (permalink / raw)
To: Alex Williamson; +Cc: qemu-devel, kvm, avi
On Wed, Jul 14, 2010 at 01:36:49PM -0600, Alex Williamson wrote:
> If we've unregistered a memory area, we should avoid calling
> qemu_get_ram_ptr() on the left over phys_offset cruft in the
> slot array. Now that we support removing ramblocks, the
> phys_offset ram_addr_t can go away and cause a lookup fault
> and abort.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Applied to uq/master branch, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-16 2:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 19:36 [Qemu-devel] [PATCH] kvm: Don't walk memory_size == 0 slots in kvm_client_migration_log Alex Williamson
2010-07-16 1:12 ` [Qemu-devel] " Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).