From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33368 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OZAkZ-0004aL-47
	for qemu-devel@nongnu.org; Wed, 14 Jul 2010 18:48:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <edgmnt@gmail.com>) id 1OZAkY-00042w-0w
	for qemu-devel@nongnu.org; Wed, 14 Jul 2010 18:48:23 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:49680)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <edgmnt@gmail.com>) id 1OZAkX-00042k-QJ
	for qemu-devel@nongnu.org; Wed, 14 Jul 2010 18:48:21 -0400
Received: by bwz19 with SMTP id 19so282223bwz.4
	for <qemu-devel@nongnu.org>; Wed, 14 Jul 2010 15:48:20 -0700 (PDT)
Sender: Eduard - Gabriel Munteanu <edgmnt@gmail.com>
Date: Thu, 15 Jul 2010 01:47:16 +0300
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer
Message-ID: <20100714224715.GA7065@localhost>
References: <1279086307-9596-1-git-send-email-eduard.munteanu@linux360.ro>
	<1279086307-9596-2-git-send-email-eduard.munteanu@linux360.ro>
	<alpine.LNX.2.00.1007141005550.4536@linmac>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1007141005550.4536@linmac>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: joro@8bytes.org, paul@codesourcery.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com

On Wed, Jul 14, 2010 at 10:07:20AM +0400, malc wrote:
> On Wed, 14 Jul 2010, Eduard - Gabriel Munteanu wrote:
> 
> > This provides an API for abstracting IOMMU functions. Hardware emulation
> > code can use it to request address translation and access checking. In
> > the absence of an emulated IOMMU, no translation/checking happens and
> > I/O goes through as before.
> > 
> > IOMMU emulation code must provide implementation-specific hooks for this
> > layer.
> > 
> 
> [..snip..]
> 
> > +int __iommu_rw(struct iommu *iommu,
> > +               DeviceState *dev,
> > +               target_phys_addr_t addr,
> > +               uint8_t *buf,
> > +               int len,
> > +               int is_write)
> 
> Do not use leading double underscore.
> 
> [..snip..]
> 
> -- 
> mailto:av1474@comtv.ru

Thanks, will fix it.


	Eduard