From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33117 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZKSg-0004Ae-7e for qemu-devel@nongnu.org; Thu, 15 Jul 2010 05:10:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZKSf-0007KD-6k for qemu-devel@nongnu.org; Thu, 15 Jul 2010 05:10:34 -0400 Received: from 8bytes.org ([88.198.83.132]:59154) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZKSf-0007K0-0o for qemu-devel@nongnu.org; Thu, 15 Jul 2010 05:10:33 -0400 Date: Thu, 15 Jul 2010 11:10:31 +0200 From: Joerg Roedel Subject: Re: [Qemu-devel] Re: [RFC PATCH 4/7] ide: IOMMU support Message-ID: <20100715091031.GD23755@8bytes.org> References: <1279086307-9596-1-git-send-email-eduard.munteanu@linux360.ro> <201007141453.06131.paul@codesourcery.com> <20100714183343.GB23755@8bytes.org> <201007142113.44913.paul@codesourcery.com> <4C3E2C2E.70507@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C3E2C2E.70507@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: avi@redhat.com, Eduard - Gabriel Munteanu , Paul Brook , kvm@vger.kernel.org, qemu-devel@nongnu.org On Wed, Jul 14, 2010 at 04:29:18PM -0500, Anthony Liguori wrote: > On 07/14/2010 03:13 PM, Paul Brook wrote: >> Well, ok, the function name needs fixing too. However I think the only thing >> missing from the current API is that it does not provide a way to determine >> which device is performing the access. > > I agree with Paul. > > The right approach IMHO is to convert devices to use bus-specific > functions to access memory. The bus specific functions should have a > device argument as the first parameter. If this means a seperate interface for device dma accesses and not fold that functionality into the cpu_physical_memory* interface I agree too :-) Joerg