qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Christoph Hellwig <hch@lst.de>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Make default invocation of block drivers safer
Date: Thu, 15 Jul 2010 10:20:56 +0100	[thread overview]
Message-ID: <20100715092056.GA14564@redhat.com> (raw)
In-Reply-To: <4C3E06DA.8080302@codemonkey.ws>

On Wed, Jul 14, 2010 at 01:50:02PM -0500, Anthony Liguori wrote:
> On 07/14/2010 01:43 PM, Christoph Hellwig wrote:
> >Err, strong NACK.  Please don't start messing with the contents of the
> >data plane, we're getting into real trouble there.  It's perfectly
> >valid for a guest to create an image inside an image, and with hardware
> >support for nested virtualization I guess this use case will become
> >rather common, just as it already is on S/390 with VM.
> >   
> 
> Then we have to remove block format probing.
> 
> The two things are fundamentally incompatible.

FWIW, the latest libvirt code will now always set a fmt=XXX arg even
for raw, so probing will never be performed. We also always set a backing
store format when creating qcow2 files.

The main remaining unsolved issues are backing stores with non-qcow2 
files for which QEMU will always probe, and pre-existing qcow2 files
which have been created without backing store formats.  It would be 
nice to have an explicit arg to disable all backing store probing, 
forcing backing format to either be raw, or match the parent image 
format.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

  reply	other threads:[~2010-07-15  9:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 16:12 [Qemu-devel] [PATCH] Make default invocation of block drivers safer Anthony Liguori
2010-07-14 16:42 ` [Qemu-devel] " Kevin Wolf
2010-07-14 17:40   ` Anthony Liguori
2010-07-15  8:00     ` Kevin Wolf
2010-07-14 18:43 ` [Qemu-devel] " Christoph Hellwig
2010-07-14 18:50   ` Anthony Liguori
2010-07-15  9:20     ` Daniel P. Berrange [this message]
2010-07-15 12:35       ` Anthony Liguori
2010-07-15 15:19     ` Markus Armbruster
2010-07-15 16:20       ` Anthony Liguori
2010-07-15 17:10         ` Kevin Wolf
2010-07-15 17:51           ` Anthony Liguori
2010-07-16  7:30             ` Kevin Wolf
2010-07-16 12:55         ` Stefan Hajnoczi
2010-07-16 13:00           ` Stefan Hajnoczi
2010-07-16 16:06         ` Markus Armbruster
2010-07-16 16:16           ` Anthony Liguori
2010-07-16 16:24             ` Kevin Wolf
2010-07-14 18:53   ` Anthony Liguori
2010-07-14 18:54   ` Aurelien Jarno
2010-07-14 19:04     ` Anthony Liguori
2010-07-15  8:09   ` Kevin Wolf
2010-07-15  9:10     ` Stefan Hajnoczi
2010-07-15 12:57       ` Anthony Liguori
2010-07-15 13:16         ` Kevin Wolf
2010-07-15 13:20         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100715092056.GA14564@redhat.com \
    --to=berrange@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).