From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge.
Date: Fri, 16 Jul 2010 10:35:53 +0300 [thread overview]
Message-ID: <20100716073553.GA21454@redhat.com> (raw)
In-Reply-To: <20100716014651.GA32307@valinux.co.jp>
On Fri, Jul 16, 2010 at 10:46:52AM +0900, Isaku Yamahata wrote:
> On Thu, Jul 08, 2010 at 07:49:35PM +0300, Michael S. Tsirkin wrote:
>
> > > For root bus:
> > > - pci_host_bus_new()/pci_host_bus_new_inplace()
> > > qbus style api. pci segment must be specified.
> > > New code should use this.
> >
> > I'd prefer a simple _init which works like _inplace.
> > Allocating memory is simple enough for users.
>
> How about the following patch?
> - replaced pci_bus_new(), pci_bus_new_inplace() with
> pci_host_bus_init()/pci_host_bus_cleanup()
> - eliminated memory allocation by embedding PCIBus into PCIHostState.
> I've tested it with only piix4 yet.
> If this direction is okay, I'll give it more tests and post it.
>
Looks good to me. What do others think? Let's also make
pci_host_bus_init_simple inline.
--
MST
next prev parent reply other threads:[~2010-07-16 7:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 2:30 [Qemu-devel] [PATCH 0/2] pci: split out bridge code into pci_bridge Isaku Yamahata
2010-07-02 2:30 ` [Qemu-devel] [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge Isaku Yamahata
2010-07-06 12:18 ` [Qemu-devel] " Michael S. Tsirkin
2010-07-07 2:38 ` Isaku Yamahata
2010-07-07 11:47 ` Michael S. Tsirkin
2010-07-08 6:39 ` Isaku Yamahata
2010-07-08 14:04 ` Michael S. Tsirkin
2010-07-08 15:43 ` Isaku Yamahata
2010-07-08 16:49 ` Michael S. Tsirkin
2010-07-09 2:07 ` Isaku Yamahata
2010-07-16 1:46 ` Isaku Yamahata
2010-07-16 7:35 ` Michael S. Tsirkin [this message]
2010-07-02 2:30 ` [Qemu-devel] [PATCH 2/2] pci/bridge: split out pci bridge code into pci_bridge.c from pci.c Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716073553.GA21454@redhat.com \
--to=mst@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).