From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57336 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObaFC-0001Nd-Jc for qemu-devel@nongnu.org; Wed, 21 Jul 2010 10:25:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObaFB-0008Cr-L0 for qemu-devel@nongnu.org; Wed, 21 Jul 2010 10:25:58 -0400 Received: from verein.lst.de ([213.95.11.210]:49024) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObaFB-0008CX-Cw for qemu-devel@nongnu.org; Wed, 21 Jul 2010 10:25:57 -0400 Date: Wed, 21 Jul 2010 16:25:55 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH v3] Error on O_DIRECT for physical CDROM/DVD drives Message-ID: <20100721142555.GA23320@lst.de> References: <1279698319-31158-1-git-send-email-Jes.Sorensen@redhat.com> <20100721131526.GA19963@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Jes.Sorensen@redhat.com, Christoph Hellwig , qemu-devel@nongnu.org On Wed, Jul 21, 2010 at 04:13:10PM +0200, Markus Armbruster wrote: > Agreed, but I figure Jes's fix is the best we can do for .13, and worth > doing for .13. As said in the previous mail it's incorrect in many ways. If at all you could reject devices and files on filesysystems on device with sector size > 512 bytes. But once that infrastructure is there fixing it for real should be rather trivial. I'm looking into it now.