From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59346 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Obdu2-0004a5-Qb
	for qemu-devel@nongnu.org; Wed, 21 Jul 2010 14:20:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Obdu1-00013S-QY
	for qemu-devel@nongnu.org; Wed, 21 Jul 2010 14:20:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57953)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Obdu1-00013H-F8
	for qemu-devel@nongnu.org; Wed, 21 Jul 2010 14:20:21 -0400
Date: Wed, 21 Jul 2010 15:20:12 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100721152012.0783c253@redhat.com>
In-Reply-To: <20100721175119.GN21281@redhat.com>
References: <1279558287-9446-1-git-send-email-miguel.filho@gmail.com>
	<1279558287-9446-3-git-send-email-miguel.filho@gmail.com>
	<20100721144228.07969f8a@redhat.com>
	<20100721175119.GN21281@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3 2/2] monitor: Convert 'info qdm' to QMP
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: avi@redhat.com, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, qemu-devel@nongnu.org, armbru@redhat.com

On Wed, 21 Jul 2010 18:51:19 +0100
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Wed, Jul 21, 2010 at 02:42:28PM -0300, Luiz Capitulino wrote:
> > On Mon, 19 Jul 2010 13:51:27 -0300
> > Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:
> > 
> > > Converts the 'info qdm' command to QMP, allowing the discovery of all devices
> > > known to the QEMU binary without relying on command line paramaters like
> > > -device ? and -device devtype,?
> > > 
> > > This change does not modify the output of the 'info qdm' monitor command.
> > > 
> > > Signed-off-by: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
> > > diff --git a/monitor.c b/monitor.c
> > > index 45fd482..66810f2 100644
> > > --- a/monitor.c
> > > +++ b/monitor.c
> > > @@ -2565,7 +2565,8 @@ static const mon_cmd_t info_cmds[] = {
> > >          .args_type  = "",
> > >          .params     = "",
> > >          .help       = "show qdev device model list",
> > > -        .mhandler.info = do_info_qdm,
> > > +        .user_print = do_info_qdm_print,
> > > +        .mhandler.info_new = do_info_qdm,
> > 
> > Haven't we agreed on calling this query-available-devices or something
> > like that?
> 
> That's getting rather verbose for a name ! How about just
> 'query-dev-types' (anticipating future query-netdev-types,
> query-chardev-types, commands etc, too)

I don't mind long names in the protocol, but I'm ok with your suggestion.