From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44309 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObdSA-000891-Re for qemu-devel@nongnu.org; Wed, 21 Jul 2010 13:51:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObdS1-0004A3-DQ for qemu-devel@nongnu.org; Wed, 21 Jul 2010 13:51:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21996) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObdS1-00049p-4r for qemu-devel@nongnu.org; Wed, 21 Jul 2010 13:51:25 -0400 Date: Wed, 21 Jul 2010 18:51:19 +0100 From: "Daniel P. Berrange" Message-ID: <20100721175119.GN21281@redhat.com> References: <1279558287-9446-1-git-send-email-miguel.filho@gmail.com> <1279558287-9446-3-git-send-email-miguel.filho@gmail.com> <20100721144228.07969f8a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100721144228.07969f8a@redhat.com> Subject: [Qemu-devel] Re: [PATCH v3 2/2] monitor: Convert 'info qdm' to QMP Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: avi@redhat.com, Miguel Di Ciurcio Filho , qemu-devel@nongnu.org, armbru@redhat.com On Wed, Jul 21, 2010 at 02:42:28PM -0300, Luiz Capitulino wrote: > On Mon, 19 Jul 2010 13:51:27 -0300 > Miguel Di Ciurcio Filho wrote: > > > Converts the 'info qdm' command to QMP, allowing the discovery of all devices > > known to the QEMU binary without relying on command line paramaters like > > -device ? and -device devtype,? > > > > This change does not modify the output of the 'info qdm' monitor command. > > > > Signed-off-by: Miguel Di Ciurcio Filho > > diff --git a/monitor.c b/monitor.c > > index 45fd482..66810f2 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -2565,7 +2565,8 @@ static const mon_cmd_t info_cmds[] = { > > .args_type = "", > > .params = "", > > .help = "show qdev device model list", > > - .mhandler.info = do_info_qdm, > > + .user_print = do_info_qdm_print, > > + .mhandler.info_new = do_info_qdm, > > Haven't we agreed on calling this query-available-devices or something > like that? That's getting rather verbose for a name ! How about just 'query-dev-types' (anticipating future query-netdev-types, query-chardev-types, commands etc, too) Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|