From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44968 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObjuU-0002iZ-1U for qemu-devel@nongnu.org; Wed, 21 Jul 2010 20:45:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObjuS-0002I7-P2 for qemu-devel@nongnu.org; Wed, 21 Jul 2010 20:45:13 -0400 Received: from mail2.shareable.org ([80.68.89.115]:40461) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObjuS-0002HZ-Kv for qemu-devel@nongnu.org; Wed, 21 Jul 2010 20:45:12 -0400 Date: Thu, 22 Jul 2010 01:45:01 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help Message-ID: <20100722004501.GK14589@shareable.org> References: <4C4704FC020000480009AB6E@sinclair.provo.novell.com> <4C475EC0.2000805@codemonkey.ws> <20100721213238.GB28871@redhat.com> <4C476A8A.6000707@codemonkey.ws> <20100721215833.GC28871@redhat.com> <4C478534.2020106@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C478534.2020106@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Bruce Rogers Anthony Liguori wrote: > On 07/21/2010 04:58 PM, Daniel P. Berrange wrote: > >>Yes there is. Use the version number. > >> > >The version number is not suitable, because features can be removed at > >compile time and/or > > I don't see any features that libvirt would need to know about that are > disabled at compile time that aren't disabled by platform features (i.e. > being on a Linux vs. Windows host). > > > added via patch backports. > > If a distro backports a feature, it should change the QEMU version > string. If it doesn't, that's a distro problem. To what version? It can't use the newer version if it only backports a subset of features; it would have to use a distro-specific version number or a version string that somehow encodes feature independent of the version number itself, by some agreed libvirt standard. Which isn't far off advertising features in the help string :-) -- Jamie