From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48185 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ObrDx-000713-0l
	for qemu-devel@nongnu.org; Thu, 22 Jul 2010 04:33:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1ObrDv-0003aV-Ru
	for qemu-devel@nongnu.org; Thu, 22 Jul 2010 04:33:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32920)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1ObrDv-0003aG-LL
	for qemu-devel@nongnu.org; Thu, 22 Jul 2010 04:33:47 -0400
Date: Thu, 22 Jul 2010 11:28:27 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] pci: split out bridge code into
	pci_bridge and make it library
Message-ID: <20100722082827.GD26168@redhat.com>
References: <cover.1278993504.git.yamahata@valinux.co.jp>
	<20100722023332.GE8531@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100722023332.GE8531@valinux.co.jp>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org

On Thu, Jul 22, 2010 at 11:33:32AM +0900, Isaku Yamahata wrote:
> Ping?

You said you will rebase and repost?

> On Tue, Jul 13, 2010 at 01:01:38PM +0900, Isaku Yamahata wrote:
> > Changes v2 -> v1:
>                 v3
> > - dropped first patch as it is merdged.
> > - rebased to mst's pci branch.
> > - eliminated pci_brdige_qdev_register(), pci_brdige_create(),
> >   pci_brdige_create_simple() by exporting PCIBus and PCIBridge.
> > 
> > Patch description:
> > Now pci.c has grown. So split bridge related code into dedicated file
> > for further extension to pci bridge. Further clean up and pcie port emulator. 
> > This make patch conflict less possible in future.
> > 
> > Clean up of pci host bus ans piix pci as discussed with v1
> > will be addressed after this patch set is accepted.
> > 
> > changes v1 -> v2:
> > - introduce pci_internals.h to accomodate pci internal strcutures to
> >   share between pci.c and pci_bridge.c
> > - don't make PCIBridge::bus pointer as suggested by
> >   Michael S. Tsirkin <mst@redhat.com>
> > - rename PCIBridge::bus -> PCIBridge::sec_bus
> > - eliminate pci_reguster_secondary_bus()/pci_unregister_secondary_bus()
> > - document pci bridge library functions.
> > - introduced pci bridge library.
> > 
> > Isaku Yamahata (4):
> >   pci/bridge: split out pci bridge code into pci_bridge.c from pci.c
> >   pci_bridge: rename PCIBridge::bus -> PCIBridge::sec_bus.
> >   pci_bridge: clean up: remove pci_{register,
> >     unregister}_secondary_bus()
> >   pci_bridge: introduce pci bridge library.
> > 
> >  Makefile.objs      |    2 +-
> >  hw/apb_pci.c       |   56 +++++++++++---
> >  hw/dec_pci.c       |   46 +++++++++--
> >  hw/pci.c           |  177 +-------------------------------------------
> >  hw/pci.h           |    5 +-
> >  hw/pci_bridge.c    |  210 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  hw/pci_bridge.h    |   62 +++++++++++++++
> >  hw/pci_internals.h |   17 +++-
> >  qemu-common.h      |    1 +
> >  9 files changed, 369 insertions(+), 207 deletions(-)
> >  create mode 100644 hw/pci_bridge.c
> >  create mode 100644 hw/pci_bridge.h
> > 
> > 
> 
> -- 
> yamahata