Re: [Qemu-devel] [PATCH v3 0/4] pci: split out bridge code into pci_bridge and make it library

[Isaku Yamahata <yamahata@valinux.co.jp>]

On Thu, Jul 22, 2010 at 11:28:27AM +0300, Michael S. Tsirkin wrote:
> On Thu, Jul 22, 2010 at 11:33:32AM +0900, Isaku Yamahata wrote:
> > Ping?
> 
> You said you will rebase and repost?

This is it. Probably there was a race between them

> 
> > On Tue, Jul 13, 2010 at 01:01:38PM +0900, Isaku Yamahata wrote:
> > > Changes v2 -> v1:
> >                 v3
> > > - dropped first patch as it is merdged.
> > > - rebased to mst's pci branch.
> > > - eliminated pci_brdige_qdev_register(), pci_brdige_create(),
> > >   pci_brdige_create_simple() by exporting PCIBus and PCIBridge.
> > > 
> > > Patch description:
> > > Now pci.c has grown. So split bridge related code into dedicated file
> > > for further extension to pci bridge. Further clean up and pcie port emulator. 
> > > This make patch conflict less possible in future.
> > > 
> > > Clean up of pci host bus ans piix pci as discussed with v1
> > > will be addressed after this patch set is accepted.
> > > 
> > > changes v1 -> v2:
> > > - introduce pci_internals.h to accomodate pci internal strcutures to
> > >   share between pci.c and pci_bridge.c
> > > - don't make PCIBridge::bus pointer as suggested by
> > >   Michael S. Tsirkin <mst@redhat.com>
> > > - rename PCIBridge::bus -> PCIBridge::sec_bus
> > > - eliminate pci_reguster_secondary_bus()/pci_unregister_secondary_bus()
> > > - document pci bridge library functions.
> > > - introduced pci bridge library.
> > > 
> > > Isaku Yamahata (4):
> > >   pci/bridge: split out pci bridge code into pci_bridge.c from pci.c
> > >   pci_bridge: rename PCIBridge::bus -> PCIBridge::sec_bus.
> > >   pci_bridge: clean up: remove pci_{register,
> > >     unregister}_secondary_bus()
> > >   pci_bridge: introduce pci bridge library.
> > > 
> > >  Makefile.objs      |    2 +-
> > >  hw/apb_pci.c       |   56 +++++++++++---
> > >  hw/dec_pci.c       |   46 +++++++++--
> > >  hw/pci.c           |  177 +-------------------------------------------
> > >  hw/pci.h           |    5 +-
> > >  hw/pci_bridge.c    |  210 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  hw/pci_bridge.h    |   62 +++++++++++++++
> > >  hw/pci_internals.h |   17 +++-
> > >  qemu-common.h      |    1 +
> > >  9 files changed, 369 insertions(+), 207 deletions(-)
> > >  create mode 100644 hw/pci_bridge.c
> > >  create mode 100644 hw/pci_bridge.h
> > > 
> > > 
> > 
> > -- 
> > yamahata
> 

-- 
yamahata