* [Qemu-devel] [PATCH] virtio-serial: Fix compat property name
@ 2010-06-23 17:19 Amit Shah
2010-07-14 13:31 ` Amit Shah
2010-07-22 12:14 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Amit Shah @ 2010-06-23 17:19 UTC (permalink / raw)
To: qemu list; +Cc: Amit Shah, Michael S. Tsirkin, Juan Quintela
Starting with qemu -M pc-0.12 -device virtio-serial
results in
-device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
that.
Also fix the ppc440 machine type bamboo-0.12 which has this typo.
Reported-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/pc_piix.c | 6 +++---
hw/ppc440_bamboo.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 68040b7..84e6c7f 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -222,7 +222,7 @@ static QEMUMachine pc_machine_v0_12 = {
.compat_props = (GlobalProperty[]) {
{
.driver = "virtio-serial-pci",
- .property = "max_nr_ports",
+ .property = "max_ports",
.value = stringify(1),
},{
.driver = "virtio-serial-pci",
@@ -245,7 +245,7 @@ static QEMUMachine pc_machine_v0_11 = {
.value = stringify(0),
},{
.driver = "virtio-serial-pci",
- .property = "max_nr_ports",
+ .property = "max_ports",
.value = stringify(1),
},{
.driver = "virtio-serial-pci",
@@ -284,7 +284,7 @@ static QEMUMachine pc_machine_v0_10 = {
.value = stringify(PCI_CLASS_DISPLAY_OTHER),
},{
.driver = "virtio-serial-pci",
- .property = "max_nr_ports",
+ .property = "max_ports",
.value = stringify(1),
},{
.driver = "virtio-serial-pci",
diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
index 6ca873e..d471d5d 100644
--- a/hw/ppc440_bamboo.c
+++ b/hw/ppc440_bamboo.c
@@ -186,7 +186,7 @@ static QEMUMachine bamboo_machine_v0_12 = {
.compat_props = (GlobalProperty[]) {
{
.driver = "virtio-serial-pci",
- .property = "max_nr_ports",
+ .property = "max_ports",
.value = stringify(1),
},{
.driver = "virtio-serial-pci",
--
1.7.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-serial: Fix compat property name
2010-06-23 17:19 [Qemu-devel] [PATCH] virtio-serial: Fix compat property name Amit Shah
@ 2010-07-14 13:31 ` Amit Shah
2010-07-22 12:14 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Amit Shah @ 2010-07-14 13:31 UTC (permalink / raw)
To: qemu list; +Cc: Juan Quintela, Michael S. Tsirkin
On (Wed) Jun 23 2010 [22:49:20], Amit Shah wrote:
> Starting with qemu -M pc-0.12 -device virtio-serial
>
> results in
>
> -device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
>
> The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
> that.
>
> Also fix the ppc440 machine type bamboo-0.12 which has this typo.
>
> Reported-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
Ping
Amit
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-serial: Fix compat property name
2010-06-23 17:19 [Qemu-devel] [PATCH] virtio-serial: Fix compat property name Amit Shah
2010-07-14 13:31 ` Amit Shah
@ 2010-07-22 12:14 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-07-22 12:14 UTC (permalink / raw)
To: Amit Shah; +Cc: qemu list
On Wed, Jun 23, 2010 at 10:49:20PM +0530, Amit Shah wrote:
> Starting with qemu -M pc-0.12 -device virtio-serial
>
> results in
>
> -device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
>
> The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
> that.
>
> Also fix the ppc440 machine type bamboo-0.12 which has this typo.
>
> Reported-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
> hw/pc_piix.c | 6 +++---
> hw/ppc440_bamboo.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
Thanks, applied.
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 68040b7..84e6c7f 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -222,7 +222,7 @@ static QEMUMachine pc_machine_v0_12 = {
> .compat_props = (GlobalProperty[]) {
> {
> .driver = "virtio-serial-pci",
> - .property = "max_nr_ports",
> + .property = "max_ports",
> .value = stringify(1),
> },{
> .driver = "virtio-serial-pci",
> @@ -245,7 +245,7 @@ static QEMUMachine pc_machine_v0_11 = {
> .value = stringify(0),
> },{
> .driver = "virtio-serial-pci",
> - .property = "max_nr_ports",
> + .property = "max_ports",
> .value = stringify(1),
> },{
> .driver = "virtio-serial-pci",
> @@ -284,7 +284,7 @@ static QEMUMachine pc_machine_v0_10 = {
> .value = stringify(PCI_CLASS_DISPLAY_OTHER),
> },{
> .driver = "virtio-serial-pci",
> - .property = "max_nr_ports",
> + .property = "max_ports",
> .value = stringify(1),
> },{
> .driver = "virtio-serial-pci",
> diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
> index 6ca873e..d471d5d 100644
> --- a/hw/ppc440_bamboo.c
> +++ b/hw/ppc440_bamboo.c
> @@ -186,7 +186,7 @@ static QEMUMachine bamboo_machine_v0_12 = {
> .compat_props = (GlobalProperty[]) {
> {
> .driver = "virtio-serial-pci",
> - .property = "max_nr_ports",
> + .property = "max_ports",
> .value = stringify(1),
> },{
> .driver = "virtio-serial-pci",
> --
> 1.7.0.1
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-22 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-23 17:19 [Qemu-devel] [PATCH] virtio-serial: Fix compat property name Amit Shah
2010-07-14 13:31 ` Amit Shah
2010-07-22 12:14 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).