[Qemu-devel] [PATCH] Remove dead code

[Qemu-devel] [PATCH] Remove dead code

[Amit Shah]

vl.c contains some dead code that initialises a 'label' string with the name
of the char device being initialised. This is unused.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 vl.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/vl.c b/vl.c
index f8c0d00..1d1ea64 100644
--- a/vl.c
+++ b/vl.c
@@ -6007,8 +6007,6 @@ int main(int argc, char **argv, char **envp)
     for(i = 0; i < MAX_SERIAL_PORTS; i++) {
         const char *devname = serial_devices[i];
         if (devname && strcmp(devname, "none")) {
-            char label[32];
-            snprintf(label, sizeof(label), "serial%d", i);
             if (strstart(devname, "vc", 0))
                 qemu_chr_printf(serial_hds[i], "serial%d console\r\n", i);
         }
@@ -6017,8 +6015,6 @@ int main(int argc, char **argv, char **envp)
     for(i = 0; i < MAX_PARALLEL_PORTS; i++) {
         const char *devname = parallel_devices[i];
         if (devname && strcmp(devname, "none")) {
-            char label[32];
-            snprintf(label, sizeof(label), "parallel%d", i);
             if (strstart(devname, "vc", 0))
                 qemu_chr_printf(parallel_hds[i], "parallel%d console\r\n", i);
         }
@@ -6027,8 +6023,6 @@ int main(int argc, char **argv, char **envp)
     for(i = 0; i < MAX_VIRTIO_CONSOLES; i++) {
         const char *devname = virtio_consoles[i];
         if (virtcon_hds[i] && devname) {
-            char label[32];
-            snprintf(label, sizeof(label), "virtcon%d", i);
             if (strstart(devname, "vc", 0))
                 qemu_chr_printf(virtcon_hds[i], "virtio console%d\r\n", i);
         }
-- 
1.6.0.6

[Qemu-devel] [patch] remove dead code

[Jun Koi]

this patch removes unused function cpu_restore_state_copy().

Signed-off-by: Jun Koi <junkoi2004@gmail.com>




diff --git a/exec-all.h b/exec-all.h
index 58b5575..3a53fe6 100644
--- a/exec-all.h
+++ b/exec-all.h
@@ -86,9 +86,6 @@ int cpu_gen_code(CPUState *env, struct TranslationBlock *tb,
 int cpu_restore_state(struct TranslationBlock *tb,
                       CPUState *env, unsigned long searched_pc,
                       void *puc);
-int cpu_restore_state_copy(struct TranslationBlock *tb,
-                           CPUState *env, unsigned long searched_pc,
-                           void *puc);
 void cpu_resume_from_signal(CPUState *env1, void *puc);
 void cpu_io_recompile(CPUState *env, void *retaddr);
 TranslationBlock *tb_gen_code(CPUState *env,

Re: [Qemu-devel] [patch] remove dead code

[Edgar E. Iglesias]

On Fri, Jul 23, 2010 at 02:57:40PM +0900, Jun Koi wrote:
> this patch removes unused function cpu_restore_state_copy().
> 
> Signed-off-by: Jun Koi <junkoi2004@gmail.com>

Applied, thanks.


> 
> diff --git a/exec-all.h b/exec-all.h
> index 58b5575..3a53fe6 100644
> --- a/exec-all.h
> +++ b/exec-all.h
> @@ -86,9 +86,6 @@ int cpu_gen_code(CPUState *env, struct TranslationBlock *tb,
>  int cpu_restore_state(struct TranslationBlock *tb,
>                        CPUState *env, unsigned long searched_pc,
>                        void *puc);
> -int cpu_restore_state_copy(struct TranslationBlock *tb,
> -                           CPUState *env, unsigned long searched_pc,
> -                           void *puc);
>  void cpu_resume_from_signal(CPUState *env1, void *puc);
>  void cpu_io_recompile(CPUState *env, void *retaddr);
>  TranslationBlock *tb_gen_code(CPUState *env,
>