From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38474 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ock5F-0003Rc-Tj
	for qemu-devel@nongnu.org; Sat, 24 Jul 2010 15:08:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1Ock5E-0005L4-N6
	for qemu-devel@nongnu.org; Sat, 24 Jul 2010 15:08:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25046)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1Ock5E-0005Kr-GR
	for qemu-devel@nongnu.org; Sat, 24 Jul 2010 15:08:28 -0400
Date: Sat, 24 Jul 2010 22:03:00 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100724190300.GB3728@redhat.com>
References: <1279898202-7223-1-git-send-email-Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1279898202-7223-1-git-send-email-Jes.Sorensen@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] vhost_dev_unassign_memory() don't assert
 if removing first entry in list.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org

On Fri, Jul 23, 2010 at 05:16:42PM +0200, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> If removing an entry from the list which is fully included in the
> region and this is the first entry in the list. In this case 'to' can
> go to -1, which is perfectly valid. Don't assert() on this case.
> 
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> ---
>  hw/vhost.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/vhost.c b/hw/vhost.c
> index d37a66e..f30cf91 100644
> --- a/hw/vhost.c
> +++ b/hw/vhost.c
> @@ -119,7 +119,6 @@ static void vhost_dev_unassign_memory(struct vhost_dev *dev,
>          if (start_addr <= reg->guest_phys_addr && memlast >= reglast) {
>              --dev->mem->nregions;
>              --to;
> -            assert(to >= 0);
>              ++overlap_middle;
>              continue;
>          }

Good catch.
I think I must have meant dev->mem->nregions >= 0.  Does this work
if you put in that assertion, or did I miss something else?

> -- 
> 1.7.1.1