From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35818 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OdM1h-00078L-Td
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 07:39:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OdM1c-0002HZ-S1
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 07:39:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29942)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OdM1c-0002HI-I8
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 07:39:16 -0400
Date: Mon, 26 Jul 2010 14:33:30 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100726113330.GC22683@redhat.com>
References: <cover.1280141797.git.yamahata@valinux.co.jp>
	<4ee70a31481376d2a3e02df95d69e3d79c8db19f.1280141797.git.yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ee70a31481376d2a3e02df95d69e3d79c8db19f.1280141797.git.yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 2/3] pci/pci_host: pci host bus
	initialization clean up.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Huacai Chen <zltjiangshi@gmail.com>, qemu-devel@nongnu.org, Takashi YOSHII <takasi-y@ops.dti.ne.jp>, Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>, Aurelien Jarno <aurelien@aurel32.net>

> +/*
> + * TODO: there remains some boards which doesn't use PCIHostState.
> + *       Enhance PCIHostState API and convert remaining boards.

I think I remember this comment from Paul:
	On Tuesday 12 January 2010, Isaku Yamahata wrote:
	> To use pci host framework, use PCIHostState instead of PCIBus in                                                
	>  PCIVPBState.                                                                                                   

	No.

	pci_host.[ch] provides very specific functionality, it is not a generic
	PCI host device. Specifically it provides indirect access to PCI config
	space via a memory mapped {address,data} pair. The versatile PCI host exposes PCI
	config space directly, so should not be using this code.

	If you want a generic framework for PCI hosts then you need to use
	something else. If nothing else, assuming that a PCI host bridge is always is
	SysBus device is wrong.

Still applies?

-- 
MST