From: Amit Shah <amit.shah@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Chris Wright <chrisw@redhat.com>,
Cole Robinson <crobinso@redhat.com>,
qemu-devel@nongnu.org, libvirt-list@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Introduce a -libvirt-caps flag as a stop-gap
Date: Wed, 28 Jul 2010 14:27:19 +0530 [thread overview]
Message-ID: <20100728085719.GA28960@amit-laptop.redhat.com> (raw)
In-Reply-To: <1280246103-6636-1-git-send-email-aliguori@us.ibm.com>
On (Tue) Jul 27 2010 [10:55:03], Anthony Liguori wrote:
> + case QEMU_OPTION_libvirt_caps:
> + printf("version: " QEMU_VERSION "\n"
> + "package: " QEMU_PKGVERSION "\n"
> + "caps: name,enable-kvm,no-reboot,uuid,xen-domid,drive"
> + ",cache-v2,format,vga,serial,mem-path,chardev,balloon"
> + ",device,rtc,netdev,sdl,topology\n");
> + exit(0);
> + break;
This can't work; people have to remember not only to update
documentation but also this case here to ensure libvirt works fine.
There are some other options that might work:
- making such a list by taking the savevm section name and version
number for each device
- The parameters supported by devices registered with qdev (and their
defaults)
- etc.
But basically this means libvirt will have to do more work now and also
add support for capabilities later. We can instead just keep 0.13 as it
is and move to capabilities for 0.14.
Amit
prev parent reply other threads:[~2010-07-28 8:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 15:55 [Qemu-devel] [PATCH] Introduce a -libvirt-caps flag as a stop-gap Anthony Liguori
2010-07-27 16:09 ` [Qemu-devel] " Daniel P. Berrange
2010-07-27 16:38 ` Anthony Liguori
2010-07-27 17:00 ` Daniel P. Berrange
2010-07-27 17:20 ` Anthony Liguori
2010-07-28 9:53 ` Daniel P. Berrange
2010-07-28 13:44 ` Anthony Liguori
2010-07-27 17:41 ` Chris Wright
2010-07-28 4:52 ` Avi Kivity
2010-07-28 8:57 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728085719.GA28960@amit-laptop.redhat.com \
--to=amit.shah@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=chrisw@redhat.com \
--cc=crobinso@redhat.com \
--cc=libvirt-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).