From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40507 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oe2SV-0005cu-Vi for qemu-devel@nongnu.org; Wed, 28 Jul 2010 04:58:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oe2S9-0004J2-D0 for qemu-devel@nongnu.org; Wed, 28 Jul 2010 04:57:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11918) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oe2S9-0004Ie-67 for qemu-devel@nongnu.org; Wed, 28 Jul 2010 04:57:29 -0400 Date: Wed, 28 Jul 2010 14:27:19 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH] Introduce a -libvirt-caps flag as a stop-gap Message-ID: <20100728085719.GA28960@amit-laptop.redhat.com> References: <1280246103-6636-1-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1280246103-6636-1-git-send-email-aliguori@us.ibm.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Chris Wright , Cole Robinson , qemu-devel@nongnu.org, libvirt-list@redhat.com On (Tue) Jul 27 2010 [10:55:03], Anthony Liguori wrote: > + case QEMU_OPTION_libvirt_caps: > + printf("version: " QEMU_VERSION "\n" > + "package: " QEMU_PKGVERSION "\n" > + "caps: name,enable-kvm,no-reboot,uuid,xen-domid,drive" > + ",cache-v2,format,vga,serial,mem-path,chardev,balloon" > + ",device,rtc,netdev,sdl,topology\n"); > + exit(0); > + break; This can't work; people have to remember not only to update documentation but also this case here to ensure libvirt works fine. There are some other options that might work: - making such a list by taking the savevm section name and version number for each device - The parameters supported by devices registered with qdev (and their defaults) - etc. But basically this means libvirt will have to do more work now and also add support for capabilities later. We can instead just keep 0.13 as it is and move to capabilities for 0.14. Amit