From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47496 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeNFT-0007Je-Fr for qemu-devel@nongnu.org; Thu, 29 Jul 2010 03:09:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OeNFS-0006kz-1N for qemu-devel@nongnu.org; Thu, 29 Jul 2010 03:09:47 -0400 Received: from mail-ey0-f173.google.com ([209.85.215.173]:44566) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeNFR-0006kt-Q3 for qemu-devel@nongnu.org; Thu, 29 Jul 2010 03:09:45 -0400 Received: by eyb6 with SMTP id 6so12330eyb.4 for ; Thu, 29 Jul 2010 00:09:44 -0700 (PDT) Date: Thu, 29 Jul 2010 09:09:41 +0200 From: "Edgar E. Iglesias" Subject: Re: [Qemu-devel] [PATCH 00/12 v4] Clean up linux-user/elfload.c Message-ID: <20100729070941.GA16888@laped.lan> References: <1280251538-6860-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1280251538-6860-1-git-send-email-rth@twiddle.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Tue, Jul 27, 2010 at 10:25:26AM -0700, Richard Henderson wrote: > A re-based and re-tested version of a patch series I > posted back in April and May. These cleanups prepare > elfload.c for loading the VDSO for x86_64. I got a whitespace warning when applying the patches: Applying: linux-user: Reduce lseek+reads while loading elf files. /home/edgar/src/c/qemu/git/qemu/.git/rebase-apply/patch:219: trailing whitespace. /* Read a good amount of data initially, to hopefully get all the warning: 1 line adds whitespace errors. I removed the trailing whitespace and fixed the interpreter less ELF loading on my side and applied the series. If there are more issues with the pre-existing realloc malc commented on, I think those can be handled with follow up patches. Thanks, Edgar > > > r~ > > > Richard Henderson (12): > linux-user: Handle filesz < memsz for any PT_LOAD segment. > Add more DT_* and AT_* constants to qemu's copy of elf.h. > linux-user: Reindent elfload.c. > linux-user: Reduce lseek+reads while loading elf files. > linux-user: Define ELF_DATA generically. > linux-user: Clean up byte-swapping in elfload.c. > linux-user: Load symbols from the interpreter. > linux-user: Improve consistency checking in elf headers. > linux-user: Put the stack guard page at the top. > linux-user: Remove partial support for a.out interpreters. > linux-user: Extract load_elf_image from load_elf_interp. > linux-user: Re-use load_elf_image for the main binary. > > elf.h | 44 ++ > linux-user/elfload.c | 1791 ++++++++++++++++++++---------------------------- > linux-user/linuxload.c | 17 +- > linux-user/qemu.h | 7 +- > 4 files changed, 794 insertions(+), 1065 deletions(-) > >