From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38373 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oeprh-000594-Lv
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 09:43:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Oeprf-0002Xs-VV
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 09:43:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48533)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Oeprf-0002XS-Mk
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 09:43:07 -0400
Date: Fri, 30 Jul 2010 10:43:01 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting
	and generate a default name
Message-ID: <20100730104301.50b3f1a1@redhat.com>
In-Reply-To: <m3r5ilcny6.fsf@blackfin.pond.sub.org>
References: <1280345424-12918-1-git-send-email-miguel.filho@gmail.com>
	<1280345424-12918-4-git-send-email-miguel.filho@gmail.com>
	<m3r5ilcny6.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, clalance@redhat.com, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, qemu-devel@nongnu.org

On Fri, 30 Jul 2010 11:34:57 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Miguel Di Ciurcio Filho <miguel.filho@gmail.com> writes:
> 
> > This patch address two issues.
> >
> > 1) When savevm is run using an previously saved snapshot id or name, it will
> > delete the original and create a new one, using the same id and name and not
> > prompting the user of what just happened.
> >
> > This behaviour is not good, IMHO.
> 
> Debatable.

Automatically destroying previously saved data without any notice seems
a quite bad behavior to me.

> > We add a '-f' parameter to savevm, to really force that to happen, in case the
> > user really wants to.
> 
> Incompatible change, looks like it'll break libvirt.  Doesn't mean we
> can't do it ever, but right now may not be the best time.  Perhaps after
> savevm & friends are fully functional in QMP.

Chris, could you please check whether this impacts libvirt?