From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39522 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oeqwq-0004do-7o
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:52:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Oeqwp-0006HC-6X
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:52:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54618)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Oeqwo-0006Gy-VJ
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:52:31 -0400
Date: Fri, 30 Jul 2010 11:52:23 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting
	and generate a default name
Message-ID: <20100730115223.70adec0d@redhat.com>
In-Reply-To: <m3aap981z6.fsf@blackfin.pond.sub.org>
References: <1280345424-12918-1-git-send-email-miguel.filho@gmail.com>
	<1280345424-12918-4-git-send-email-miguel.filho@gmail.com>
	<m3r5ilcny6.fsf@blackfin.pond.sub.org>
	<20100730104301.50b3f1a1@redhat.com>
	<m3aap981z6.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, clalance@redhat.com, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, qemu-devel@nongnu.org

On Fri, 30 Jul 2010 16:43:09 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Fri, 30 Jul 2010 11:34:57 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Miguel Di Ciurcio Filho <miguel.filho@gmail.com> writes:
> >> 
> >> > This patch address two issues.
> >> >
> >> > 1) When savevm is run using an previously saved snapshot id or name, it will
> >> > delete the original and create a new one, using the same id and name and not
> >> > prompting the user of what just happened.
> >> >
> >> > This behaviour is not good, IMHO.
> >> 
> >> Debatable.
> >
> > Automatically destroying previously saved data without any notice seems
> > a quite bad behavior to me.
> 
> See cp, mv ;)

Nah, unrelated because the name of the command imply that. A best comparison
would be lvcreate have such semantics.