qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: [Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name
Date: Fri, 30 Jul 2010 11:53:16 -0300	[thread overview]
Message-ID: <20100730115316.00b9f921@redhat.com> (raw)
In-Reply-To: <AANLkTineY8=d+r6GjdBosZF_QF68+aGftb9xKwFOe2r3@mail.gmail.com>

On Fri, 30 Jul 2010 11:42:44 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino
> <lcapitulino@redhat.com> wrote:
> >>
> >> TODO: I have no clue on how to create a timestamp string when using Windows.
> >
> > So, what happens on windows?
> >
> 
> I've found some code in bdrv_snapshot_dump() that formats a timestamp
> when using Windows. I will use it as a basis.

How hard would be for you to test it, we shouldn't commit untested code.

      reply	other threads:[~2010-07-30 14:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 19:30 [Qemu-devel] [PATCH 0/3] savem: various cleanups Miguel Di Ciurcio Filho
2010-07-28 19:30 ` [Qemu-devel] [PATCH 1/3] cleanup: bdrv_snaphost_find() returns zero or -ENOENT Miguel Di Ciurcio Filho
2010-07-30  9:44   ` Markus Armbruster
2010-07-30 13:38     ` Luiz Capitulino
2010-07-28 19:30 ` [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code Miguel Di Ciurcio Filho
2010-07-30  9:45   ` Markus Armbruster
2010-07-30 20:28     ` Miguel Di Ciurcio Filho
2010-08-02 11:06       ` Markus Armbruster
2010-07-28 19:30 ` [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name Miguel Di Ciurcio Filho
2010-07-30  9:34   ` Markus Armbruster
2010-07-30 13:43     ` Luiz Capitulino
2010-07-30 14:43       ` Markus Armbruster
2010-07-30 14:52         ` Luiz Capitulino
2010-08-02 14:08       ` Chris Lalancette
2010-07-30 13:39   ` [Qemu-devel] " Luiz Capitulino
2010-07-30 14:42     ` Miguel Di Ciurcio Filho
2010-07-30 14:53       ` Luiz Capitulino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100730115316.00b9f921@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=miguel.filho@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).