From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39623 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oeqxg-00054C-Tx
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:53:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Oeqxf-0006NC-MO
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:53:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59428)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Oeqxf-0006N4-FO
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:53:23 -0400
Date: Fri, 30 Jul 2010 11:53:16 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100730115316.00b9f921@redhat.com>
In-Reply-To: <AANLkTineY8=d+r6GjdBosZF_QF68+aGftb9xKwFOe2r3@mail.gmail.com>
References: <1280345424-12918-1-git-send-email-miguel.filho@gmail.com>
	<1280345424-12918-4-git-send-email-miguel.filho@gmail.com>
	<20100730103906.551adacd@redhat.com>
	<AANLkTineY8=d+r6GjdBosZF_QF68+aGftb9xKwFOe2r3@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting
 and generate a default name
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Fri, 30 Jul 2010 11:42:44 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino
> <lcapitulino@redhat.com> wrote:
> >>
> >> TODO: I have no clue on how to create a timestamp string when using Windows.
> >
> > So, what happens on windows?
> >
> 
> I've found some code in bdrv_snapshot_dump() that formats a timestamp
> when using Windows. I will use it as a basis.

How hard would be for you to test it, we shouldn't commit untested code.