From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51854 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfE0B-00065G-H9 for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfE0A-0001XP-Ex for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:29:31 -0400 Received: from hall.aurel32.net ([88.191.82.174]:43485) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfE0A-0001X4-9t for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:29:30 -0400 Date: Sat, 31 Jul 2010 17:29:21 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode Message-ID: <20100731152921.GL20459@volta.aurel32.net> References: <1279900598-8432-1-git-send-email-Jes.Sorensen@redhat.com> <20100730210847.GD20459@volta.aurel32.net> <4C53E9FD.4070109@redhat.com> <20100731141944.GC31640@hall.aurel32.net> <4C5435C5.2040402@redhat.com> <20100731151318.GF31640@hall.aurel32.net> <4C543F7E.5020300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4C543F7E.5020300@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Alex.Williamson@redhat.com, qemu-devel@nongnu.org On Sat, Jul 31, 2010 at 05:21:34PM +0200, Jes Sorensen wrote: > On 07/31/10 17:13, Aurelien Jarno wrote: > > On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: > >> If you want that, please do it in a separate patch for the entire file, > >> otherwise it will never become consistent. However it doesn't change the > >> issue either that putting braces around a single line like this is bad > >> coding style. > > > > We got this discussions numerous times, and I am not going to start it > > again. If you want to see the patch applied, just follow the rules. > > > > Then I would like to know why you do not apply this silly rule to every > patch submitted. There's patches going in almost every day that doesn't > use this hopeless formatting. > Because not everyone try to enforce the rules. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net