From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46753 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ofwy6-0008KF-ID for qemu-devel@nongnu.org; Mon, 02 Aug 2010 11:30:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ofwy5-00010A-8k for qemu-devel@nongnu.org; Mon, 02 Aug 2010 11:30:22 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:42262) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ofwy5-0000zv-6g for qemu-devel@nongnu.org; Mon, 02 Aug 2010 11:30:21 -0400 Received: by qyk31 with SMTP id 31so61390qyk.4 for ; Mon, 02 Aug 2010 08:30:20 -0700 (PDT) Date: Mon, 2 Aug 2010 11:30:16 -0400 From: Kevin O'Connor Message-ID: <20100802153016.GA9031@morn.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCHv2] Fix USB mouse Set_Protocol behavior List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The QEMU USB mouse claims to support the "boot" protocol (bInterfaceSubClass is 1). However, the mouse rejects the Set_Protocol command. The qemu mouse does support the "boot" protocol specification, so a simple fix is to enable the Set_Protocol request. Signed-off-by: Kevin O'Connor --- Changes v1->v2: Add signed-off-by line. --- hw/usb-hid.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 882d933..d54823d 100644 --- a/hw/usb-hid.c +++ b/hw/usb-hid.c @@ -791,13 +791,13 @@ static int usb_hid_handle_control(USBDevice *dev, int request, int value, goto fail; break; case GET_PROTOCOL: - if (s->kind != USB_KEYBOARD) + if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE) goto fail; ret = 1; data[0] = s->protocol; break; case SET_PROTOCOL: - if (s->kind != USB_KEYBOARD) + if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE) goto fail; ret = 0; s->protocol = value; -- 1.7.2