From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58255 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OgH6q-0003o4-9f
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 09:00:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OgH6Y-0003M4-Kt
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 09:00:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8980)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OgH6Y-0003Ke-9V
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 09:00:26 -0400
Date: Tue, 3 Aug 2010 10:00:16 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] QEMUFileBuffered: indicate that we're
	ready when the underlying file is ready
Message-ID: <20100803100016.268293ce@redhat.com>
In-Reply-To: <4C57B364.8090500@redhat.com>
References: <1278521062-13795-1-git-send-email-avi@redhat.com>
	<4C57B364.8090500@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, 03 Aug 2010 09:12:52 +0300
Avi Kivity <avi@redhat.com> wrote:

>   On 07/07/2010 07:44 PM, Avi Kivity wrote:
> > QEMUFileBuffered stops writing when the underlying QEMUFile is not ready,
> > and tells its producer so.  However, when the underlying QEMUFile becomes
> > ready, it neglects to pass that information along, resulting in stoppage
> > of all data until the next tick (a tenths of a second).
> >
> > Usually this doesn't matter, because most QEMUFiles used with QEMUFileBuffered
> > are almost always ready, but in the case of exec: migration this is not true,
> > due to the small pipe buffers used to connect to the target process.  The
> > result is very slow migration.
> >
> > Fix by detecting the readiness notification and propagating it.  The detection
> > is a little ugly since QEMUFile overloads put_buffer() to send it, but that's
> > the suject for a different patch.
> 
> Ping.

I've queued this fix and another one in a 'for-0.13' branch and was planning
to send a pull request as soon as Anthony called for 0.13 fixes, however
this didn't happen yet and I forgot.