From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39566 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OgGUw-0001MP-7f for qemu-devel@nongnu.org; Tue, 03 Aug 2010 08:21:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OgGQi-0004Q7-Br for qemu-devel@nongnu.org; Tue, 03 Aug 2010 08:17:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16590) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OgGQi-0004Pn-4g for qemu-devel@nongnu.org; Tue, 03 Aug 2010 08:17:12 -0400 Date: Tue, 3 Aug 2010 08:17:06 -0400 From: Glauber Costa Message-ID: <20100803121706.GN14448@mothafucka.localdomain> References: <20100802211121.5497.36512.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100802211121.5497.36512.stgit@localhost6.localdomain6> Subject: [Qemu-devel] Re: [PATCH] e1000: Fix hotplug List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org On Mon, Aug 02, 2010 at 03:15:17PM -0600, Alex Williamson wrote: > When we hotplug the device, > we don't go through a reset cycle, which means a hot added e1000 is > useless until the VM reboots. I do guess, however, that this is true for any device, right? Wouldn't it be better to just call the newly added reset function at hotplug? One way to do that, would be to store a value indicated qemu has already started. If you add a reset handler after that, the function is called before being placed on the list.