From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37156 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OgpWt-0004jZ-MN
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 21:45:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <yamahata@valinux.co.jp>) id 1OgpWs-0005UG-M2
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 21:45:55 -0400
Received: from mail.valinux.co.jp ([210.128.90.3]:58606)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <yamahata@valinux.co.jp>) id 1OgpWs-0005Tv-BU
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 21:45:54 -0400
Date: Thu, 5 Aug 2010 10:51:37 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Subject: Re: [Qemu-devel] Re: [PATCH 2/3] pci/pci_host: pci host bus
	initialization clean up.
Message-ID: <20100805015137.GL4446@valinux.co.jp>
References: <cover.1280141797.git.yamahata@valinux.co.jp>
	<4ee70a31481376d2a3e02df95d69e3d79c8db19f.1280141797.git.yamahata@valinux.co.jp>
	<20100726113330.GC22683@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100726113330.GC22683@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Huacai Chen <zltjiangshi@gmail.com>, qemu-devel@nongnu.org, Takashi YOSHII <takasi-y@ops.dti.ne.jp>, Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>, Aurelien Jarno <aurelien@aurel32.net>

On Mon, Jul 26, 2010 at 02:33:30PM +0300, Michael S. Tsirkin wrote:
> > +/*
> > + * TODO: there remains some boards which doesn't use PCIHostState.
> > + *       Enhance PCIHostState API and convert remaining boards.
> 
> I think I remember this comment from Paul:
> 	On Tuesday 12 January 2010, Isaku Yamahata wrote:
> 	> To use pci host framework, use PCIHostState instead of PCIBus in                                                
> 	>  PCIVPBState.                                                                                                   
> 
> 	No.
> 
> 	pci_host.[ch] provides very specific functionality, it is not a generic
> 	PCI host device. Specifically it provides indirect access to PCI config
> 	space via a memory mapped {address,data} pair. The versatile PCI host exposes PCI
> 	config space directly, so should not be using this code.
> 
> 	If you want a generic framework for PCI hosts then you need to use
> 	something else. If nothing else, assuming that a PCI host bridge is always is
> 	SysBus device is wrong.
> 
> Still applies?

No objection? Paul, do you have any comment?
-- 
yamahata